a58e9c7a9e
Refactor server shutdown to call Close() on conn and sync on srv.started
...
Remove the necessity for the hackish (and unreliable) fake packet.
Fix a couple races and unclutter the start/stop internal state.
2015-10-07 00:13:40 +01:00
3c158e6e74
Correct set srv.started to false on error
...
Unlock the lock and set started to false when we return an error
during the startup.
Fixes #263
2015-09-23 22:00:38 +01:00
540899743c
Handle the last TCP connection
...
We currently close the connection after 128 TCP queries. But the
when the last query comes in, we close the connection immediately.
Fix this by moving the check to before we read data from the TCP
socket.
Fixes : #218 .
2015-08-31 17:40:56 +01:00
114b68f41b
go vet fixes
2015-08-23 07:24:08 +01:00
a6742d536c
Lock zone pattern deletion too
...
Go 1.5 -race flags this as data race, it's not performance critical,
add locking on the mutex.
2015-08-22 18:31:23 +01:00
eac4ea318f
Revert "Use defer Unlock() in ListAndServe"
...
This reverts commit d2cb5e8fef
2015-08-17 11:11:14 +01:00
d2cb5e8fef
Use defer Unlock() in ListAndServe
2015-08-12 07:49:41 +01:00
1cb2437ad1
fix some data races in Server
...
This avoids some issues with Server.PacketConn and Server.Listener being
accessed outside of their locks.
Fixes #244 .
2015-08-11 17:00:14 -07:00
bbe3422804
small doc fixes
2015-08-09 15:34:29 +01:00
8255b4a03f
update docs; replace "data frame" refs with "raw message"
2015-08-06 17:55:37 -04:00
e148c23156
add docs and example for DNS frame read/write decorators
2015-08-04 09:04:40 -04:00
e0f83dee9a
add interfaces to allow packet-level inspection for pre/post processing
2015-08-04 01:17:14 -04:00
5a357a6fc5
Expose the udp/tcp listening socket w/ ListenAndServe()
...
Expose the udp and tcp listening socket when ListenAndServe() is used, it seems like
plopping them on Server.Listener and Server.PacketConn would be ideal. The use case is so
that a port of zero can be used and having them exposed will allow for examination of the port
that is bound.
2015-04-18 06:52:30 +01:00
9ef29b5646
Export UDP interfaces
2015-03-09 15:00:21 -07:00
67945c119e
A bunch of golint fixes
...
The proposed vars names are a nono, because they break the API.
Things left: document each RR and zscan_rr.go has some funcky if-then-elses.
2015-02-19 09:58:33 +00:00
24ccdb3008
fix spelling of separate
2015-02-18 17:04:12 -05:00
2b6f0d61e5
When locking *do* unlock
...
Add unlocking to some more places as pointed out by bronze1man.
Really closes #161 .
2015-01-13 08:12:02 +00:00
a07be6b2c1
Server: unlock when already started.
...
Closes #161
2015-01-11 09:26:00 +00:00
79f88fc5d7
fmt
2015-01-11 09:23:26 +00:00
8da60e45f5
Remove refs to IsMsg - we are not going to do this
2015-01-08 09:42:46 +00:00
2c1a31d550
Small cleanup of the docs
2014-12-12 12:57:47 +00:00
f039fd8203
Add NotifyStartedFunc field to Server
...
Adds a field, NotifyStartedFunc func() to Server.
If non-nil, it is called after a server starts listening. This is useful
for synchronization purposes, for example when a daemon needs to drop
privileges after binding. Otherwise, there is no way to determine when
the server has begun listening and hardcoded delays (!) must be used or
race conditions may occur.
2014-12-12 12:51:17 +00:00
cd2048a15a
Add Unsafe member to dns.Server
...
This stops it from checking if the incoming requests have the QR bit
unset, so be careful when enabling this. This can be useful in
combination with mDNS.
Also the check for only 1 question in the question section is relaxed
to be "at least one", even without setting Unsafe!
Also update TestServingResponse to test for Unsafe vs not using Unsafe.
2014-11-19 16:34:18 +00:00
61478ac390
Removed duplicated test for UDPSize
2014-11-18 15:59:40 +00:00
d8da4d2fa7
Fix: drop requests with *cough* qr set.
...
Err, yeah.
2014-10-19 09:36:26 +00:00
0aa3021a83
Remove all copyright notices
...
Use the central COPYRIGHT file.
2014-09-11 20:57:37 +01:00
fbc3e49b78
Some documentation updates
2014-09-02 10:31:15 +00:00
ebc5489482
Fix datarace in Start/Shutdown
...
Add mutex and guard a 'started' boolean as well as the stopUDP
and tcpTCP channels so that 'go test -race' does not trigger.
Closes #111 , closes #114
2014-08-30 10:34:44 +01:00
fce659ba46
Restored code when shutdown needs an exchange...
...
Clients sents NULL-packet to server which helps to avoid
timeout. Timeout is still possible to encounter.
Shutdown will likely report error for those cases.
2014-08-29 14:27:53 -04:00
c618657d9b
Dealt with race condition detector warnings:
...
* stopped obvious race condition with replacing handler in
ServingLargeResponses test
* lowered probability of other race conditions with test code
while test server is yet activating
* fixed errmessage in Shutdown
2014-08-29 14:10:05 -04:00
ef07b9a69a
Following up in introducing getReadTimeout()
2014-08-29 12:26:23 -04:00
f735bb9dcb
Changed how shutdown works...
...
Now stopXXX event will stop any reading on currently open
socket and terminate reading loop. No special client/server
message is required anymore.
2014-08-29 12:24:11 -04:00
32d6e5396e
Continued removing Sleeping tests:
...
* incorporated @miekg suggestions on switch vs if
* for now moved reaction to stopXXX channel messages until
after the packet is responded to avoid client timeout in
Shutdown (causing 2 sec. hanged thread)
Still not great how the abort logic is implemented....
2014-08-29 08:31:27 -04:00
4b21f37064
Proposed way of creating no-timeout tests and...
...
... fix for Server.Shutdown() function.
2014-08-28 23:11:49 -04:00
2127b822dd
Add comment about Systemd
2014-08-28 07:54:23 +00:00
f0bd4137e2
Make Shutdown return error
...
This will be handy in feature, so that we can add a 1 second
timeout and then return failure.
2014-08-20 15:12:59 +00:00
01bbcbef60
Update documentation for Shutdown.
...
This completes issue #101 .
Fixes #101
2014-08-19 22:08:13 +01:00
eed2b9aeec
Fix Shutdown
2014-08-19 21:56:37 +01:00
f912994258
Don't relay on deadline to stop the server.
...
We just send ourselves an UDP or TCP packet so that the listener fails
through and picks up the quit bool send on the channel.
2014-08-19 21:46:00 +01:00
6c631cd4ff
Implement Shutdown()
...
This is working for TCP, but for UDP the Read does not honor the
deadline settings.
2014-08-19 09:25:41 +00:00
292c925c9f
update documentation
2014-08-18 22:21:02 +01:00
0d300b1fce
Add deadline to the listeners
...
Call this deadline to the listener will timeout and we will get to
so if the server should shutdown.
2014-08-18 22:14:29 +01:00
f3a6c86462
Implement Shutdown() call
...
And fix some tests to call Fatal().
2014-08-18 22:06:29 +01:00
6cf24a5637
Add a Shutdown method to server.
...
Allow gracefull shutdown of a server.
2014-08-18 20:30:10 +01:00
eb2d26cb96
Remove Pool from server.
...
A noop for some time, remove it.
2014-08-18 20:29:54 +01:00
fb3a1585ad
fmt
2014-07-27 20:38:11 +01:00
0a6f133b26
Match format of other code
2014-07-27 10:44:39 -07:00
12f91af6ed
Added ResponseWriter.LocalAddr support
2014-07-27 10:43:07 -07:00
62ee88c895
Documentation
2014-07-22 08:27:59 +01:00
e1cb18539a
Systemd support
...
Rename StartAndServe to ActivateAndServe and only use one PacketConn or
Listener. This just adds a new entry point into starting a server.
2014-07-21 15:24:55 +01:00
Filippo Valsorda
Miek Gieben
Jeff Hodges
James DeFelice
Robert Gordon
Peter M. Goldstein
Matthew Farrellee
Hugo Landau
Bryan Boreham
Alex Sergeyev
Luke Young