Commit Graph

3277 Commits

Author SHA1 Message Date
Filippo Valsorda 40484667f4 rewrite NSEC bitmap [un]packing to account for out-of-order 2015-08-05 00:18:02 +01:00
Filippo Valsorda 2b564cd047 UnpackDomainName: fix infinite loop where it would lower 'off'
When a pointer points to a empty name, the "return '.'" special case used to
kick in which is not pointer-aware so it would reset the parsing offset to
the pointer target

This was independently found and fixed in c13d4ee, I'm submitting this patch
anyway as it seems a bit more robust and DRY [citation needed].
2015-08-05 00:18:02 +01:00
Filippo Valsorda 77aa064ef9 packStructValue: rewrite dns:"wks" packing which was writing out of bounds 2015-08-05 00:18:02 +01:00
Filippo Valsorda 0df69faa6e packStructValue: fix a overflow in NSEC packing 2015-08-05 00:18:02 +01:00
Filippo Valsorda b5133fead4 unpackStructValue: drop rdlen, reslice msg instead 2015-08-05 00:18:02 +01:00
Filippo Valsorda 6313235fed unpackStructValue: fix a overflow in opt 2015-08-05 00:18:01 +01:00
Miek Gieben 14e381d23e fuzzzz 2015-07-27 21:48:46 +01:00
Miek Gieben fcf516f280 fuzzzz 2015-07-27 20:57:02 +01:00
Miek Gieben c13d4ee9cd domain names: fix compression of root-label
If the root label is compressed (which is 2 bytes, the root label
itself is only 1 byte, so why do it?), go dns incorrectly set the
offset when encountering such a name.

Fixes #234
2015-07-27 20:48:09 +01:00
Miek Gieben e59f851c91 Merge pull request #231 from rolandshoemaker/master
Correct CAA len method and octet packing buffer
2015-07-22 19:55:50 +01:00
Roland Shoemaker 259969e797 Better buffer size 2015-07-21 16:04:21 -07:00
Roland Shoemaker eefb8a37ac Merge remote-tracking branch 'upstream/master' 2015-07-20 13:23:13 -07:00
Roland Shoemaker ce1812cfaf Add byte packing/unpacking test 2015-07-20 13:21:13 -07:00
Miek Gieben 3825eda935 Merge pull request #230 from sajal/master
adding TurboBytes Pulse as a user
2015-07-17 16:36:07 +01:00
Sajal Kayan 7bebd64196 adding TurboBytes Pulse as a user 2015-07-17 21:58:41 +07:00
Miek Gieben 63b32eb7eb Merge pull request #229 from rafaeljusto/invalid-idna
change function return behaviour on error
2015-07-17 13:26:08 +01:00
Rafael Dantas Justo c1abafe6ad add final dot in function comment 2015-07-17 07:17:18 -03:00
Rafael Dantas Justo 0ec31bb825 encode function should return nil when an invalid character is detected and
ToPunycode function should return an empty string when there's an invalid
domain name
2015-07-16 13:02:51 -03:00
Miek Gieben dbbb279025 Merge pull request #228 from rafaeljusto/invalid-idna
check label for invalid code points
2015-07-16 13:18:44 +01:00
Rafael Dantas Justo aab9736a4e better name for the file that store the code points list 2015-07-16 08:05:59 -03:00
Rafael Dantas Justo 4071a397d6 drop idna from names as we already are in the idn package and also avoid "else
if" when it's not necessary
2015-07-16 08:05:25 -03:00
Rafael Dantas Justo 0096e2aae0 moving logic from idna_table.go to punycode.go 2015-07-15 16:28:22 -03:00
Rafael Dantas Justo 340d862d2f check label for invalid code points according to RFC 5892, appendix B.1 2015-07-15 15:13:19 -03:00
Roland Shoemaker 3d5407e128 Fix CAA packing bug 2015-07-07 20:20:25 +01:00
Miek Gieben 3e549e2f6f And of course the test too 2015-07-03 09:34:46 +01:00
Miek Gieben 2f503031b0 Rename to ReadMsgHeader
Slightly more descriptive and remove the underscore of _DNSHeaderSize
and call is headerSize.
2015-07-03 09:31:53 +01:00
Miek Gieben 6a8b26eb31 Merge pull request #224 from asergeyev/master
Added function for lazy message reading per #222
2015-07-03 09:24:25 +01:00
Alex Sergeyev b0d6ff308e Fixed things found in code review (comments, semantics). 2015-07-02 22:42:02 -04:00
Alex Sergeyev b625f190ce Not allocating 64K buffers for reading 2015-06-29 08:06:49 -04:00
Alex Sergeyev 53dfadf090 Shortened ReadMsg using ReadMsgBytes, added a constant. 2015-06-28 20:21:37 -04:00
Alex Sergeyev 2f3bcbd506 Added function for lazy message reading per #222 2015-06-28 20:21:37 -04:00
Miek Gieben ad7777796e Add link to web article explaining it further 2015-06-25 07:33:30 +01:00
Miek Gieben 6da0cd2c92 CAA now also be tested in TestDynamicUpdateParsing 2015-06-19 08:23:26 +01:00
Miek Gieben 65752c4214 Merge pull request #219 from rolandshoemaker/caa
Fix CAA parsing
2015-06-19 08:20:59 +01:00
Roland Shoemaker 52647ae7a7 Address miekg's comments 2015-06-18 19:17:02 -07:00
Roland Shoemaker 020002b9e0 Switch setCAA, CAA.String to presentation format, add various encoding helpers 2015-06-17 16:06:31 -07:00
Miek Gieben db86274360 Merge pull request #221 from asergeyev/master
Minor fixes (see description)
2015-06-17 07:20:22 +01:00
Alex Sergeyev 387c041985 Changed logic around reserving wire read buffer 2015-06-16 21:21:22 -04:00
Alex Sergeyev 416c39c6e9 Removed redundant code #220 2015-06-16 19:24:38 -04:00
Roland Shoemaker 1995ce2be4 Fix unpacking 2015-06-16 13:55:19 -07:00
Roland Shoemaker e745789a1e Fix typo 2015-06-16 11:57:09 -07:00
Roland Shoemaker 522331911d Enable CAA parsing 2015-06-16 02:01:28 -07:00
Miek Gieben 7864d445e5 Merge pull request #217 from flebarbe/master
Fix crash in inIxfr when ReadMsg fails
2015-06-05 14:32:24 +01:00
Flavien Lebarbe bc2101d0db Fix crash in inIxfr when ReadMsg fails
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x5dc851]

goroutine 41 [running]:
github.com/miekg/dns.(*Transfer).inIxfr(0xc2127648d0, 0x437bcc, 0xc21678c600)
        /mnt/data/xxxxx/third-party/src/github.com/miekg/dns/xfr.go:110 +0x231
created by github.com/miekg/dns.func·073
        /mnt/data/xxxxx/third-party/src/github.com/miekg/dns/xfr.go:45 +0xf5
2015-06-05 14:59:53 +02:00
Miek Gieben bb1103f648 Merge pull request #212 from asergeyev/master
Changes for rarely-used RR types
2015-05-07 19:35:36 +01:00
Alex Sergeyev 0bc16d74c9 Added comment to commented-out testcase 2015-05-07 12:12:39 -04:00
Alex Sergeyev 32bf0823e2 Support for almost all possible ways to format HINFO record 2015-05-07 12:09:05 -04:00
Alex Sergeyev fe15681571 Fixed reversed logic. 2015-05-07 11:31:23 -04:00
Alex Sergeyev 2e9176243e Updated NSAP support according to RFC1706
New text format 0x and no more length in the object itself.
2015-05-07 10:18:47 -04:00
Alex Sergeyev d2bed60478 Fixed SSHFP parsing when multiple lines used for text representation. 2015-05-07 09:50:44 -04:00