community
/
dns
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename to ReadMsgHeader 

Slightly more descriptive and remove the underscore of _DNSHeaderSize
and call is headerSize.
This commit is contained in:
Miek Gieben 2015-07-03 09:31:53 +01:00
parent 6a8b26eb31
commit 2f503031b0
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
client.go
View File

@ -189,7 +189,7 @@ func (c *Client) exchange(m *Msg, a string) (r *Msg, rtt time.Duration, err erro
// If the received message contains a TSIG record the transaction
// signature is verified.
func (co *Conn) ReadMsg() (*Msg, error) {
p, err := co.ReadMsgBytes(nil)
p, err := co.ReadMsgHeader(nil)
if err != nil {
return nil, err
}
@ -208,10 +208,10 @@ func (co *Conn) ReadMsg() (*Msg, error) {
return m, err
}
// ReadMsgBytes reads a DNS message, parses and populates hdr (when hdr is not nil).
// Returns message as a byte slice to pasrse with Msg.Unpack later on.
// ReadMsgHeader reads a DNS message, parses and populates hdr (when hdr is not nil).
// Returns message as a byte slice to be parsed with Msg.Unpack later on.
// Note that error handling on the message body is not possible as only the header is parsed.
func (co *Conn) ReadMsgBytes(hdr *Header) ([]byte, error) {
func (co *Conn) ReadMsgHeader(hdr *Header) ([]byte, error) {
var (
p []byte
n int
@ -237,7 +237,7 @@ func (co *Conn) ReadMsgBytes(hdr *Header) ([]byte, error) {
if err != nil {
return nil, err
} else if n < _DNSHeaderSize {
} else if n < headerSize {
return nil, ErrShortRead
}

3
types.go
View File

@ -158,8 +158,7 @@ type Header struct {
}
const (
// Header Size
_DNSHeaderSize = 12
headerSize = 12
// Header.Bits
_QR = 1 << 15 // query/response (response=1)