community
/
dns
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: remove t.Log(f) when nothing is failing (#698) 

* tests: remove t.Log(f) when nothing is failing

This clears up the travis output some more and adheres to the Unix
saying: no output is good news
This commit is contained in:
Miek Gieben 2018-06-07 19:15:11 +01:00 committed by GitHub
parent 4c681ac41f
commit f90eb8fb45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client_test.go
View File

@ -606,7 +606,5 @@ func TestDoHExchange(t *testing.T) {
t.Errorf("failed to get an valid answer\n%v", r) t.Errorf("failed to get an valid answer\n%v", r)
} }
t.Log(r)
// TODO: proper tests for this // TODO: proper tests for this
} }

6
dns_test.go
View File

@ -296,7 +296,7 @@ func TestTKEY(t *testing.T) {
if bytes.Compare(tkeyBytes, msg[0:offset]) != 0 { if bytes.Compare(tkeyBytes, msg[0:offset]) != 0 {
t.Fatal("mismatched TKEY data after rewriting bytes") t.Fatal("mismatched TKEY data after rewriting bytes")
} }
t.Logf("got TKEY of: " + rr.String())
// Now add some bytes to this and make sure we can encode OtherData properly // Now add some bytes to this and make sure we can encode OtherData properly
tkey := rr.(*TKEY) tkey := rr.(*TKEY)
tkey.OtherData = "abcd" tkey.OtherData = "abcd"
@ -308,13 +308,11 @@ func TestTKEY(t *testing.T) {
if offset != (len(tkeyBytes) + 2) { if offset != (len(tkeyBytes) + 2) {
t.Fatalf("mismatched TKEY RR size %d != %d", offset, len(tkeyBytes)+2) t.Fatalf("mismatched TKEY RR size %d != %d", offset, len(tkeyBytes)+2)
} }
t.Logf("modified to TKEY of: " + rr.String())
// Make sure we can parse our string output // Make sure we can parse our string output
tkey.Hdr.Class = ClassINET // https://github.com/miekg/dns/issues/577 tkey.Hdr.Class = ClassINET // https://github.com/miekg/dns/issues/577
newRR, newError := NewRR(tkey.String()) _, newError := NewRR(tkey.String())
if newError != nil { if newError != nil {
t.Fatalf("unable to parse TKEY string: %s", newError) t.Fatalf("unable to parse TKEY string: %s", newError)
} }
t.Log("got reparsed TKEY of newRR: " + newRR.String())
} }