From f90eb8fb4590a3c81327ccca86ed4c4ca898c73d Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Thu, 7 Jun 2018 19:15:11 +0100 Subject: [PATCH] tests: remove t.Log(f) when nothing is failing (#698) * tests: remove t.Log(f) when nothing is failing This clears up the travis output some more and adheres to the Unix saying: no output is good news --- client_test.go | 2 -- dns_test.go | 6 ++---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/client_test.go b/client_test.go index 020e141b..81c0386a 100644 --- a/client_test.go +++ b/client_test.go @@ -606,7 +606,5 @@ func TestDoHExchange(t *testing.T) { t.Errorf("failed to get an valid answer\n%v", r) } - t.Log(r) - // TODO: proper tests for this } diff --git a/dns_test.go b/dns_test.go index 3c9d910d..1ffe8265 100644 --- a/dns_test.go +++ b/dns_test.go @@ -296,7 +296,7 @@ func TestTKEY(t *testing.T) { if bytes.Compare(tkeyBytes, msg[0:offset]) != 0 { t.Fatal("mismatched TKEY data after rewriting bytes") } - t.Logf("got TKEY of: " + rr.String()) + // Now add some bytes to this and make sure we can encode OtherData properly tkey := rr.(*TKEY) tkey.OtherData = "abcd" @@ -308,13 +308,11 @@ func TestTKEY(t *testing.T) { if offset != (len(tkeyBytes) + 2) { t.Fatalf("mismatched TKEY RR size %d != %d", offset, len(tkeyBytes)+2) } - t.Logf("modified to TKEY of: " + rr.String()) // Make sure we can parse our string output tkey.Hdr.Class = ClassINET // https://github.com/miekg/dns/issues/577 - newRR, newError := NewRR(tkey.String()) + _, newError := NewRR(tkey.String()) if newError != nil { t.Fatalf("unable to parse TKEY string: %s", newError) } - t.Log("got reparsed TKEY of newRR: " + newRR.String()) }