b0de3d08b8
Fix repo search broken because of profile page added ( #25455 ) ( #25467 )
...
Backport #25455 by @lunny
Fix #25433
Caused by #23260
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-06-23 15:48:35 +02:00
2e64449de7
Make "dismiss" content shown correctly ( #25461 ) ( #25465 )
...
Backport #25461 by @wxiaoguang
Close #25127
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-23 11:04:15 +00:00
ec539b7a77
Gitea version in Makefile ( #25456 ) ( #25457 )
...
Backport-ish of #25456
Signed-off-by: jolheiser <john.olheiser@gmail.com>
2023-06-23 09:52:03 +02:00
6fbdacb524
Support Drone building binaries too
2023-06-22 21:13:54 -04:00
948f6ca029
Remove test string ( #25447 ) ( #25448 )
...
Backport #25447
Remove test string on delete project button, I overlooked it in a
previous PR
2023-06-22 17:30:51 +00:00
061b68e995
Refactor path & config system ( #25330 ) ( #25416 )
...
Backport #25330
# The problem
There were many "path tricks":
* By default, Gitea uses its program directory as its work path
* Gitea tries to use the "work path" to guess its "custom path" and
"custom conf (app.ini)"
* Users might want to use other directories as work path
* The non-default work path should be passed to Gitea by GITEA_WORK_DIR
or "--work-path"
* But some Gitea processes are started without these values
* The "serv" process started by OpenSSH server
* The CLI sub-commands started by site admin
* The paths are guessed by SetCustomPathAndConf again and again
* The default values of "work path / custom path / custom conf" can be
changed when compiling
# The solution
* Use `InitWorkPathAndCommonConfig` to handle these path tricks, and use
test code to cover its behaviors.
* When Gitea's web server runs, write the WORK_PATH to "app.ini", this
value must be the most correct one, because if this value is not right,
users would find that the web UI doesn't work and then they should be
able to fix it.
* Then all other sub-commands can use the WORK_PATH in app.ini to
initialize their paths.
* By the way, when Gitea starts for git protocol, it shouldn't output
any log, otherwise the git protocol gets broken and client blocks
forever.
The "work path" priority is: WORK_PATH in app.ini > cmd arg --work-path
> env var GITEA_WORK_DIR > builtin default
The "app.ini" searching order is: cmd arg --config > cmd arg "work path
/ custom path" > env var "work path / custom path" > builtin default
## ⚠️ BREAKING
If your instance's "work path / custom path / custom conf" doesn't meet
the requirements (eg: work path must be absolute), Gitea will report a
fatal error and exit. You need to set these values according to the
error log.
2023-06-22 16:27:18 +00:00
734fd93f59
Move some regexp out of functions ( #25430 ) ( #25445 )
...
Partial backport of #25430
Not a bug, but worth backporting for efficiency.
Signed-off-by: jolheiser <john.olheiser@gmail.com>
2023-06-22 16:01:54 +00:00
203fe2841d
Fix `Permission` in API returned repository struct ( #25388 ) ( #25441 )
...
Backport #25388 by @wolfogre
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.
Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)
---
Review tips:
The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101
And other changes are passive.
Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
056829749e
Diff page enhancements ( #25398 ) ( #25437 )
...
Backport #25398 by @silverwind
Two small tweaks:
1. Vertically center arrow here when editing a PR:
<img width="405" alt="Screenshot 2023-06-20 at 19 48 49"
src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb ">
2. Use 2-row layout on diff viewed status and show it again on mobile:
<img width="142" alt="Screenshot 2023-06-20 at 19 51 21"
src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b ">
Mobile view:
<img width="370" alt="Screenshot 2023-06-20 at 19 44 40"
src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d ">
Co-authored-by: silverwind <me@silverwind.io>
2023-06-22 14:33:13 +02:00
f18b8e7d8a
Change default email domain for LDAP users ( #25425 ) ( #25434 )
...
Backport #25425 by @Zettat123
Fixes #21169
Change `localhost` to `localhost.local`
Co-authored-by: Zettat123 <zettat123@gmail.com>
2023-06-22 10:53:15 +00:00
ea00ed320d
Various UI fixes ( #25264 ) ( #25431 )
...
Backport #25264 by @silverwind
Numerous small UI fixes:
- Fix double border in collaborator list
- Fix system notice table background
- Mute links in repo and org lists
- Downsize projects edit buttons
- Improve milestones and project list rendering
- Condense milestone list entry to a single line of "metas"
- Mute ".." button in repo files list
<img width="899" alt="Screenshot 2023-06-14 at 21 19 23"
src="https://github.com/go-gitea/gitea/assets/115237/40d70006-5f76-49ad-b43c-4343ec3311e1 ">
<img width="905" alt="Screenshot 2023-06-14 at 21 18 29"
src="https://github.com/go-gitea/gitea/assets/115237/46ef39ea-ab26-452d-89b0-a55d0cfacfdb ">
<img width="270" alt="Screenshot 2023-06-14 at 21 14 09"
src="https://github.com/go-gitea/gitea/assets/115237/aa16e833-a03b-4231-bc7c-159a6a6bee19 ">
<img width="409" alt="Screenshot 2023-06-14 at 21 12 13"
src="https://github.com/go-gitea/gitea/assets/115237/b5242d41-f87a-4837-b0cf-9cc4c1f43daf ">
<img width="286" alt="Screenshot 2023-06-14 at 21 10 03"
src="https://github.com/go-gitea/gitea/assets/115237/d0c36e47-651b-4d34-ad95-3d59474a7c3e ">
<img width="928" alt="Screenshot 2023-06-14 at 21 05 24"
src="https://github.com/go-gitea/gitea/assets/115237/fc3b713e-d252-40f5-b6ba-6e5a741ab500 ">
<img width="217" alt="Screenshot 2023-06-14 at 21 02 01"
src="https://github.com/go-gitea/gitea/assets/115237/c4c33376-18d6-4820-aff5-f508f6d351a0 ">
<img width="79" alt="Screenshot 2023-06-14 at 20 42 43"
src="https://github.com/go-gitea/gitea/assets/115237/034b5950-c0bf-473b-a2f7-0c27a0259f29 ">
<img width="607" alt="Screenshot 2023-06-14 at 21 00 42"
src="https://github.com/go-gitea/gitea/assets/115237/fba2d3fd-bd3e-4daf-8b2f-530a1c99c8bc ">
Co-authored-by: silverwind <me@silverwind.io>
2023-06-22 10:19:38 +00:00
30a783879f
Show outdated comments in files changed tab ( #24936 ) ( #25428 )
...
Backport #24936
If enabled show a clickable label in the comment. A click on the label
opens the Conversation tab with the comment focussed - there you're able
to view the old diff (or original diff the comment was created on).
**Screenshots**
When resolved and outdated:
Option to enable/disable this (stored in user settings - default is
disabled):
fixes #24913
Co-authored-by: silverwind <me@silverwind.io>
2023-06-22 08:34:42 +00:00
cb3173a1e9
Use "utf8mb4" for MySQL by default ( #25432 )
...
TBH, I don't see much difference from `Remove "CHARSET" config option
for MySQL, always use "utf8mb4"` #25413
Close #25413
2023-06-22 07:38:23 +02:00
ffe089432f
Fix missing commit message body when the message has leading newlines ( #25418 ) ( #25422 )
...
Backport #25418 by @wolfogre
Commit with `echo "\nmessage after a blank line\nsecond line of the
message" | git commit --cleanup=verbatim -F -` and push.
<img width="1139" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/f9a2c28c-e307-4c78-9e31-3d3ace7b9274 ">
Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-21 13:55:08 +02:00
8302b95d6b
Avoid polluting config file when "save" ( #25395 ) ( #25406 )
...
Backport #25395 by @wxiaoguang
That's a longstanding INI package problem: the "MustXxx" calls change
the option values, and the following "Save" will save a lot of garbage
options into the user's config file.
Ideally we should refactor the INI package to a clear solution, but it's
a huge work.
A clear workaround is what this PR does: when "Save", load a clear INI
instance and save it.
Partially fix #25377 , the "install" page needs more fine tunes.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-21 04:51:26 +00:00
6f1c95ec5b
Use the new download domain replace the old ( #25405 ) ( #25409 )
...
Backport #25405 by @lunny
As title.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-06-21 03:59:51 +00:00
cda69a0363
Fix dropdown icon layout on diff page ( #25397 ) ( #25403 )
...
Backport #25397 by @wxiaoguang
Address
https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916
Remove the unused "icon-button".
And fix the layout:
Without the dropdown icon:
```
{{svg "gitea-whitespace"}}
```
With the dropdown icon:
```
{{svg "gitea-whitespace" 16 "gt-mr-3"}}
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
```
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-21 10:55:11 +08:00
4908cc9adf
Fix blank dir message when uploading files from web editor ( #25391 ) ( #25400 )
...
Backport #25391 by @lunny
Fix #7883
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-06-20 20:28:52 +00:00
28ed763f55
Use Actions git context instead of dynamically created buildkit one ( #25381 ) ( #25383 )
...
Backport #25381 by @techknowlogick
The [docker/build-push-action@v2
action](https://github.com/docker/build-push-action ) by default ignores
the checkout created using the actions/checkout@v2 action. When you pass
a git build context to docker build, it wouldn't include the .git
directory.
By passing `context: .` to the build step then it'll use the Actions git
context which includes the git fetch from the earlier step.
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-06-20 08:52:38 +02:00
8e89eb8f43
Update JS dependencies, remove space after emoji completion ( #25266 ) ( #25352 )
...
Manual backport of #25266 because of lockfile conflicts.
- Update all JS dependencies
- Enable stylint
[`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown )
- Make use of new features in webpack and text-expander-element
- Tested Swagger and Mermaid
To explain the `text-expander-element` change: Before this version, the
element added a unavoidable space after emoji completion. Now that
https://github.com/github/text-expander-element/pull/36 is in, we gain
control over this space and I opted to remove it for emoji completion
and retain it for `@` mentions.
Co-authored-by: Giteabot <teabot@gitea.io>
2023-06-20 05:38:52 +00:00
dfefe86045
Fix LDAP sync when Username Attribute is empty ( #25278 ) ( #25379 )
...
Backport #25278 by @Zettat123
Fix #21072
Username Attribute is not a required item when creating an
authentication source. If Username Attribute is empty, the username
value of LDAP user cannot be read, so all users from LDAP will be marked
as inactive by mistake when synchronizing external users.
This PR improves the sync logic, if username is empty, the email address
will be used to find user.
Co-authored-by: Zettat123 <zettat123@gmail.com>
2023-06-20 13:11:22 +08:00
10fcb55507
Fetch all git data for embedding correct version in docker image ( #25361 ) ( #25373 )
...
Backport #25361 by @techknowlogick
Fix #25350
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-06-20 03:07:51 +00:00
e9105ac281
Fix label list divider ( #25312 ) ( #25372 )
...
Backport #25312 by @wxiaoguang
We only needs 2 lines to hide the dividers.
```
$dropdownLabelFilter.dropdown('setting', {'hideDividers': 'empty'});
$dropdownLabelFilter.dropdown('refreshItems');
```
Other code blocks are refactored by the way.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-19 18:14:31 +00:00
e6e1cfd8e4
fix issue filters on mobile view ( #25368 ) ( #25371 )
...
Backport #25368 by @denyskon
Fix #24846 applying the solution proposed by @silverwind
<details>
<summary>Screenshots</summary>
</details>
Replaces #25335
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
2023-06-19 17:43:22 +00:00
072997692c
Fix incorrect actions ref_name ( #25358 ) ( #25367 )
...
Backport #25358 by @nephatrine
Fix #25357 .
Just a simple fix the result of `${{ gitea.ref_name }}` to show the
shortened name rather than the full ref.
Co-authored-by: Daniel Wolf <1461334+nephatrine@users.noreply.github.com>
2023-06-19 18:37:52 +02:00
e9fab3ea3e
Avoid polluting the config ( #25345 ) ( #25354 )
...
Backport #25345 by @wxiaoguang
Caught by #25330
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-18 20:56:50 +00:00
e0bd6ebabd
Fix incorrect config argument position for builtin SSH server ( #25341 )
...
The "--config" option is a global option, it shouldn't appear at the
end.
Otherwise it might not be respected in some cases.
Caught by #25330 and use a separate PR to fix it for 1.20
2023-06-18 16:56:21 +00:00
cc73f6e821
Add Exoscale to installation on cloud provider docs ( #25342 ) ( #25346 )
...
Backport #25342 by @pmig
We created a Gitea application for the [Exoscale
Marketplace](https://www.exoscale.com/marketplace/listing/glasskube-gitea/ )
for easier installation on the European cloud provider.
The installation is managed via the [Glasskube Kubernetes
Operator](https://github.com/glasskube/operator ).
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
Co-authored-by: Philip Miglinci <p.miglinci@gmail.com>
2023-06-18 15:48:06 +00:00
ff18c3ba65
Write absolute AppDataPath to app.ini when installing ( #25331 ) ( #25347 )
...
Backport #25331 by @wxiaoguang
If the APP_DATA_PATH isn't written into the config when installing, then
its value is uncertain because some Gitea command doesn't run with
correct WorkPath.
This is a quick fix for #25330 and can be backported.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-18 15:07:46 +00:00
b673edbeaf
Fix UI on mobile view ( #25315 ) ( #25340 )
...
Backport #25315 by @denyskon
Various fixes to pages or elements which were looking ugly on mobile.
<details>
<summary>Screenshots</summary>
</details>
Co-authored by: @silverwind
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-18 13:02:41 +00:00
05431593ef
Fix action runner last online state on edit page ( #25337 )
...
Backport fix for action runner last online state not showing in
`release/v1.20` - fixes #25336
2023-06-18 12:04:35 +00:00
aa4c9c3215
build nightly docker images ( #25317 ) ( #25333 )
...
Backport #25317 by @techknowlogick
followup of https://github.com/go-gitea/gitea/pull/25308 this time to
build & push nightly docker images
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-06-18 11:09:30 +00:00
4e79c76ed0
When viewing a file, hide the add button ( #25320 ) ( #25339 )
...
Backport #25320 by @hiifong
Fix #25281
When viewing a file, hide the add button
Co-authored-by: hiifong <i@hiif.ong>
2023-06-18 10:24:54 +00:00
3bd311c3f4
Remove EasyMDE focus outline on text ( #25328 ) ( #25332 )
...
Backport #25328 by @silverwind
EasyMDE in Firefox currently shows a ugly outline in the fake textarea
the CodeMirror uses. Hide it.
Before:
<img width="845" alt="Screenshot 2023-06-18 at 02 54 09"
src="https://github.com/go-gitea/gitea/assets/115237/dc406166-9ad5-4a9b-9581-002b5cdcc6df ">
After:
<img width="870" alt="Screenshot 2023-06-18 at 02 54 24"
src="https://github.com/go-gitea/gitea/assets/115237/ddd78759-2cf2-4385-b863-7576fec25c34 ">
Co-authored-by: silverwind <me@silverwind.io>
2023-06-18 09:35:40 +02:00
7e06e6a042
use Actions environment variables in Makefile ( #25319 ) ( #25318 )
2023-06-17 23:27:04 -04:00
e5629d9701
Remove more unused Fomantic variants ( #25292 ) ( #25323 )
...
Backport #25292 by @silverwind
Save another 50KB of CSS by removing unused and useless Fomantic
variants.
Removed the last instance of a `tertiary` button and fixed a TODO:
<img width="509" alt="Screenshot 2023-06-15 at 22 34 36"
src="https://github.com/go-gitea/gitea/assets/115237/8a16ae7b-2b17-439b-a096-60a52724e3d6 ">
Co-authored-by: silverwind <me@silverwind.io>
2023-06-17 17:14:25 +02:00
4ea38bba73
Build nightly binaries with Actions ( #25308 ) ( #25314 )
...
Backport #25308 by @techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-16 19:59:20 +02:00
25cb1fb994
Fix displayed RPM repo url ( #25310 ) ( #25313 )
...
Backport #25310 by @KN4CK3R
Fixes #25302
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2023-06-16 16:39:41 +00:00
e5422db5c7
Show if File is Executable ( #25287 ) ( #25300 )
...
Backport #25287 by @JakobDev
This simply shows if a File has the executable Permission
Co-authored-by: JakobDev <jakobdev@gmx.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-16 09:29:26 +00:00
3a29f6aaff
Add link to support page for commercial support ( #25293 ) ( #25297 )
...
Backport #25293 by @techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-06-16 14:26:32 +08:00
99d71b2b65
Docs about how to generate config for act runner with docker and setup it with docker-compose ( #25256 ) ( #25296 )
...
Backport #25256 by @thezzisu
In this pull request, the following changes are addressed:
- State user should create `config.yaml` before start container to avoid
errors.
- Provided instructions to deploy runners using docker compose.
Co-authored-by: Zisu Zhang <thezzisu@gmail.com>
2023-06-16 12:09:03 +08:00
783f7ccb2c
Fix some UI alignments ( #25277 ) ( #25290 )
...
Backport #25277 by @wxiaoguang
Fixes: https://github.com/go-gitea/gitea/issues/25282
Fix the problems:
1. The `repo-button-row` had various patches before, this PR makes it
consistent
2. The "Add File" has wrong CSS class "icon", remove it
3. The "Add File" padding was overridden by "!important", fix it by
`.repo-button-row .button.dropdown` with comment
4. The selector `.ui.segments ~ .ui.top.attached.header` is incorrect,
it should use `+`
The `repo-button-row` is only used on 3 pages:
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-16 00:32:59 +00:00
3f75fbf8fe
Remove fomantic inverted variations ( #25286 ) ( #25289 )
...
Backport #25286 by @silverwind
Remove all Fomantic `inverted` variations, we are no using any of them.
This reduces the index CSS bundle by 98kB.
Co-authored-by: silverwind <me@silverwind.io>
2023-06-15 12:13:03 -04:00
4124f8ef70
Fix issue and commit status popup padding ( #25254 ) ( #25288 )
...
Backport #25254 by @wxiaoguang
Close #25249
Use "dialog" for the role
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-15 16:52:23 +02:00
b45ea0280b
Show OAuth2 errors to end users ( #25261 ) ( #25271 )
...
Backport #25261 by @wxiaoguang
Partially fix #23936
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-15 02:48:36 +00:00
031ddfcb7b
Fix index generation parallelly failure ( #25235 ) ( #25269 )
...
Backport #25235 by @lunny
Fix #22109
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2023-06-15 02:14:00 +00:00
d686aa0d31
Fix profile render when the README.md size is larger than 1024 bytes ( #25270 )
...
Backport #25131
2023-06-15 01:39:34 +00:00
037366f93f
Fix edit OAuth application width ( #25262 ) ( #25263 )
...
Backport #25262 by @denyskon
The `<div class="ui container">` broke the width of this section - fix
by removing it.
Before:
After:
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
2023-06-14 20:39:51 -04:00
5191ab6445
Use flex to align SVG and text ( #25163 ) ( #25260 )
...
Backport #25163 by @wxiaoguang
The code can be as simple as:
```html
<div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div>
<div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div>
<div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div>
```
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-14 13:21:48 -04:00
bfd3eb9dbc
GitHub Actions enhancements for frontend ( #25150 ) ( #25259 )
...
Backport #25150 by @silverwind
- Don't run DB tests for frontend-only changes
- Build frontend as part of frontend step
- Build everything when actions change
Co-authored-by: silverwind <me@silverwind.io>
2023-06-14 15:59:46 +00:00
Giteabot
John Olheiser
techknowlogick
Denys Konovalov
wxiaoguang
sebastian-sauer
silverwind
derelm
yp05327