f55a6552b0
Merge pull request from GHSA-hqxw-f8mx-cpmw
...
Fix runaway allocation on /v2/_catalog
2023-05-09 21:21:54 +01:00
2b13387884
Merge pull request #3898 from ecormaksin/patch-1
...
Update configuration.md
2023-05-09 17:05:25 +01:00
ada0064ab9
Merge pull request #3905 from thaJeztah/bump_go_1.19.9
...
update to go1.19.9
2023-05-09 16:45:31 +01:00
5d301a9b3b
Update configuration.md
...
I think that `valye` is typo.
Signed-off-by: Makoto Oda <truth_jp_4133@yahoo.co.jp>
2023-05-09 17:40:20 +02:00
322eb4eecf
update to go1.19.9
...
Added back minor versions in these, so that we have a somewhat more
reproducible state in the repository when tagging releases.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 17:29:31 +02:00
681d7dcbb3
Merge pull request #3906 from thaJeztah/update_golangci_lint
...
update golangci-lint to v1.52, fix linting issues
2023-05-09 16:21:02 +01:00
4fd8ad520d
Merge pull request #3904 from thaJeztah/update_xx
...
Dockerfile: update xx to v1.2.1
2023-05-09 15:20:12 +01:00
dec03ea3d8
update golangci-lint to v1.52
...
Removing the "structcheck" and "varcheck" linters as they've been deprecated.
level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 16:04:17 +02:00
ebe9d67446
ignore SA1019: ac.(*accessController).rootCerts.Subjects has been deprecated
...
We need to look into this; can we remove it, or is there a replacement?
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 16:04:17 +02:00
84a85a4048
Ignore SA1019: SplitHostname is deprecated.
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 16:04:17 +02:00
999527f978
Ignore SA1019: "schema1 is deprecated" linting errors
...
We need to use this for backward compatibility.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 16:04:17 +02:00
3c144f2264
registry/auth/token: fix the surrounding loop is unconditionally terminate
...
registry/auth/token/types_test.go:83:3: SA4004: the surrounding loop is unconditionally terminated (staticcheck)
return
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 16:04:17 +02:00
4052d269f5
reference, registry: fix loop variable captured by func literal (govet)
...
reference/normalize_test.go:274:40: loopclosure: loop variable r captured by func literal (govet)
named, err := ParseNormalizedNamed(r)
^
reference/normalize_test.go:276:29: loopclosure: loop variable r captured by func literal (govet)
t.Fatalf("ref=%s: %v", r, err)
^
registry/api/errcode/errors_test.go:45:7: loopclosure: loop variable ec captured by func literal (govet)
if ec != desc.Code {
^
registry/api/errcode/errors_test.go:46:66: loopclosure: loop variable ec captured by func literal (govet)
t.Fatalf("error code in descriptor isn't correct, %q != %q", ec, desc.Code)
^
registry/api/errcode/errors_test.go:49:23: loopclosure: loop variable desc captured by func literal (govet)
if idToDescriptors[desc.Value].Code != ec {
^
registry/api/errcode/errors_test.go:50:80: loopclosure: loop variable desc captured by func literal (govet)
t.Fatalf("error code in idToDesc isn't correct, %q != %q", idToDescriptors[desc.Value].Code, ec)
^
registry/api/errcode/errors_test.go:53:7: loopclosure: loop variable ec captured by func literal (govet)
if ec.Message() != desc.Message {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 16:04:08 +02:00
c9b844e533
Merge pull request #3885 from thaJeztah/rename_table_tests
...
assorted test updates
2023-05-09 13:58:29 +01:00
f03d966ef7
cloudfront: use consistent names for test-tables, t.Parallel()
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 14:39:58 +02:00
5301ae14bf
cloudfront: rename vars that collided with type
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 14:00:17 +02:00
85028a801b
registry/handlers: use consistent names for test-tables
...
Also marked assertBlobUploadStateEquals as t.Helper()
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 14:00:17 +02:00
f4acd98865
registry/api/v2: checkTestRouter(): use sub-tests, t.Parallel()
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 14:00:05 +02:00
2444c3282d
registry/api/v2: use consistent names for test-tables
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:55:16 +02:00
9266220c2a
registry/auth/token: TestAudienceList_Unmarshal: t.Parallel()
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:55:16 +02:00
5e67a40e08
registry/auth/token: use consistent names for test-tables
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:55:16 +02:00
f884a079df
registry/api/errorcode: TestErrorCodes: use sub-tests
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:55:11 +02:00
57f9f31af9
notifications: don't use un-keyed structs
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:38 +02:00
e9ac1728e6
notifications: use consistent names for test tables
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:38 +02:00
f4be328bff
context: TestWithTrace(): inline checkContextForValues, use sub-tests
...
checkContextForValues was effectively running sub-tests, but disguided
as a helper (to DRY). While it helped some duplication, rewriting it to
run subtests within a helper also was a bit confusing, so just inline
what it does.
While updating, also run tests with t.Parallel()
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:37 +02:00
2829f7b7d5
context: use consistent names for test-tables
...
Also renamed a var that collided with a type, and marked a helper
as t.Helper()
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:37 +02:00
f238f7dcaa
reference: TestMatch(): use sub-tests
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:37 +02:00
2819bca991
reference: TestNormalizedSplitHostname(): use sub-tests
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:37 +02:00
fa1d14c513
reference: TestParseAnyReference(): use sub-tests
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:37 +02:00
fcbddfc6ae
reference: use consistent names for test-tables
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 13:54:37 +02:00
8c4d2b9d65
Dockerfile: update xx to v1.2.1
...
full diff: https://github.com/tonistiigi/xx/compare/v1.1.1...v1.2.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-09 12:17:52 +02:00
8900e90699
Merge pull request #3895 from pluralsh/bug-fix-5001-server-rebase
...
Fix the issue that the debug server with port 5001 run twice
2023-05-05 13:21:55 +08:00
08f7a47bc9
Merge pull request #2766 from glefloch/remove-testdriver
...
Remove registry storage testdriver
2023-05-03 21:40:53 +01:00
99a8ad00ea
fix: rename log to logrus
...
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
2023-05-03 19:02:03 +02:00
f0fdaff0a5
Fix the issue that the debug server with port 5001 run twice
...
When configuring bugsnag, bugsnag will fork the process, resulting the port 5001 listened twice. The PR fix this error by moving the initialization of prometheus server after the configuration of bugsnag
Signed-off-by: Honglin Feng <tifayuki@gmail.com>
(cherry picked from commit 5a6a2d6ae06453136f5e1cfb5e9efa20c27085d9)
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
2023-05-03 18:37:32 +02:00
4adbb690c1
Merge pull request #3795 from AdamKorcz/fuzz222
...
Fuzzing: Move over two fuzzers from cncf-fuzzing
2023-05-03 15:59:20 +01:00
e2a43ec8d3
Fuzzing: Move over two fuzzers from cncf-fuzzing
...
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-02 23:03:57 +02:00
0ea92a1a8d
Merge pull request #3883 from thaJeztah/reference_update_tests_and_add_benchmark
...
reference: rewrite test to use sub-tests, add benchmark
2023-05-02 20:55:05 +01:00
9fb201e23d
Remove registry storage testdriver
...
Signed-off-by: glefloch <glfloch@gmail.com>
2023-05-02 16:37:33 +02:00
788598e23f
Merge pull request #3881 from vvoland/handle-forbidden
...
registry/errors: Parse http forbidden as denied
2023-05-02 09:38:36 +01:00
1062ccc7ef
Merge pull request #3882 from thaJeztah/no_dot_imports
...
remove dot-imports for gopkg.in/check.v1
2023-05-01 16:21:11 +01:00
49e2de2830
reference: add BenchmarkParse
...
BenchmarkParse
BenchmarkParse-10 12696 93805 ns/op 9311 B/op 185 allocs/op
PASS
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-29 19:31:21 +02:00
b50c049fc6
reference: TestParseRepositoryInfo: use subtests
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-29 18:58:09 +02:00
af36dd698f
reference: TestParseDockerRef: capture test in loop
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-29 18:58:01 +02:00
3fa6d5a33b
remove dot-imports for gopkg.in/check.v1
...
Dot-imports were only used in a couple of places, and replacing them
makes it more explicit what's imported.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-29 17:08:47 +02:00
5f1df02149
registry/errors: Parse http forbidden as denied
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2023-04-27 19:48:32 +02:00
29b5e79f82
Merge pull request #3742 from sagikazarmark/fix-aud-claim-list
...
Accept list of strings in audience claim in token auth
2023-04-26 18:39:26 +01:00
2fb8dbdeca
Merge pull request #3839 from kirat-singh/feature.azure-sdk-update
...
Update Azure SDK and support additional authentication schemes
2023-04-25 19:35:34 +01:00
ba4a6bbe02
Update Azure SDK and support additional authentication schemes
...
Microsoft has updated the golang Azure SDK significantly. Update the
azure storage driver to use the new SDK. Add support for client
secret and MSI authentication schemes in addition to shared key
authentication.
Implement rootDirectory support for the azure storage driver to mirror
the S3 driver.
Signed-off-by: Kirat Singh <kirat.singh@beacon.io>
Co-authored-by: Cory Snider <corhere@gmail.com>
2023-04-25 17:23:20 +00:00
4c1561e9fb
Fix runaway allocation on /v2/_catalog
...
Introduced a Catalog entry in the configuration struct. With it,
it's possible to control the maximum amount of entries returned
by /v2/catalog (`GetCatalog` in registry/handlers/catalog.go).
It's set to a default value of 1000.
`GetCatalog` returns 100 entries by default if no `n` is
provided. When provided it will be validated to be between `0`
and `MaxEntries` defined in Configuration. When `n` is outside
the aforementioned boundary, an error response is returned.
`GetCatalog` now handles `n=0` gracefully with an empty response
as well.
Signed-off-by: José D. Gómez R. <1josegomezr@gmail.com>
2023-03-31 13:17:43 +02:00
Milos Gajdos
Makoto Oda
Sebastiaan van Stijn
Wang Yan
David van der Spek
Feng Honglin
AdamKorcz
glefloch
Paweł Gronowski
Kirat Singh
Jose D. Gomez R