Commit Graph

3622 Commits

Author SHA1 Message Date
Miek Gieben eac4ea318f Revert "Use defer Unlock() in ListAndServe"
This reverts commit d2cb5e8fef.
2015-08-17 11:11:14 +01:00
Miek Gieben 7ff8d29c8b Merge pull request #242 from ErikDubbelboer/lessheap
Do simple prechecks to avoid heap allocations
2015-08-13 07:55:50 +01:00
Erik Dubbelboer 6b8b49f49d Do simple prechecks to avoid heap allocations 2015-08-13 04:50:02 +00:00
Miek Gieben 0fe10e90c4 Drop go 1.3 and add go 1.5rc1 for tests 2015-08-12 07:51:12 +01:00
Miek Gieben d2cb5e8fef Use defer Unlock() in ListAndServe 2015-08-12 07:49:41 +01:00
Miek Gieben 42fa711b14 Merge pull request #245 from jmhodges/shutdown_race
fix some data races in Server
2015-08-12 07:12:09 +01:00
Jeff Hodges 1cb2437ad1 fix some data races in Server
This avoids some issues with Server.PacketConn and Server.Listener being
accessed outside of their locks.

Fixes #244.
2015-08-11 17:00:14 -07:00
Miek Gieben c2d94895af Merge pull request #243 from rafaeljusto/idn-overflow-fix
Avoid rune overflow when converting to unicode
2015-08-10 13:18:49 +01:00
Rafael Dantas Justo 7ed808b59f Avoid rune overflow when converting to unicode 2015-08-10 08:57:07 -03:00
Miek Gieben e220dd92fd Add test the crashes idn. 2015-08-10 07:36:10 +01:00
Miek Gieben f6f99a7a6d Update README about NSAP record 2015-08-10 07:30:50 +01:00
Miek Gieben 21b35db538 Remove the NSAP record
The NSAP was not implemented correctly, see #239. Just remove it. It will still work as unknown RR.
2015-08-10 07:26:35 +01:00
Miek Gieben 8eb292db07 Doc update for future change in TC handling
Update the comment in msg.go#L1700 about the TC bit handling

Small cleanups.
2015-08-09 16:26:25 +01:00
Miek Gieben bbe3422804 small doc fixes 2015-08-09 15:34:29 +01:00
Miek Gieben b1fe149a97 Check for l.err in $INCLUDE
This can throw l.err as well, and a l.length of zero, check for both.
2015-08-08 13:41:46 +01:00
Miek Gieben 3b3e522e22 A some length check to $GENERATE modifiers
Short cut these modifier lengths to 255 max. Which seems a reasonable default.
2015-08-08 13:31:38 +01:00
Miek Gieben 58c5f4cf6e Small doc updates 2015-08-07 20:58:26 +01:00
Miek Gieben d7ca9f827c And check err here as well. 2015-08-07 16:56:49 +01:00
Miek Gieben 3861fcbbb2 Fix HIP parsing 2015-08-07 16:26:37 +01:00
Miek Gieben 1897a2a983 Merge branch 'master' of github.com:miekg/dns 2015-08-07 15:06:19 +02:00
Miek Gieben d5324dc6e3 Fuzz the text parser
Check if the values send on the channel are errors, if so return
one. Otherwise continue parsing.
2015-08-07 15:01:11 +02:00
Miek Gieben 3f3bd86f55 Merge pull request #240 from sajal/master
Adding DNS debugger android app
2015-08-07 11:24:41 +01:00
Miek Gieben 69d043f8ab Better fuzzing test and NSAP fix
rr can be nil when parsed, if it, for instance only contains a
comment.

NSAP parsing need some parens to make the if-then logic work.
2015-08-07 12:17:16 +02:00
Sajal Kayan 52fdcc9417 Adding DNS debugger android app 2015-08-07 17:09:15 +07:00
Miek Gieben 1e6d260018 Fuzz NewRR
Add checks for token length == 0.
2015-08-07 10:39:21 +01:00
Miek Gieben 9de5f84650 Merge pull request #236 from jdef/serve-wrapper
add interfaces to allow packet-level inspection for pre/post processing
2015-08-07 07:22:22 +01:00
Andrew Tunnell-Jones b1bc8d70f4 Add AXFR tests run against SIDN's DNS Workbench 2015-08-07 05:30:19 +00:00
James DeFelice 8255b4a03f update docs; replace "data frame" refs with "raw message" 2015-08-06 17:55:37 -04:00
Miek Gieben e3d247cbf6 Merge pull request #238 from gowthamgts/patch-1
Added Cloudflare to the user list.
2015-08-06 20:36:48 +01:00
Gowtham Gopalakrishnan 87dbfff5f1 Added Cloudflare to the user list.
Read more here: https://blog.cloudflare.com/dns-parser-meet-go-fuzzer/
2015-08-06 23:28:55 +05:30
Miek Gieben 8fdd5c33f8 Merge pull request #237 from FiloSottile/fuzz-rampage
Fuzz rampage!
2015-08-05 07:06:10 +01:00
Filippo Valsorda 4a26a5bbbf EDNS0_SUBNET: refactor netmask handling
Added some more symmetric sanity checks when packing and unpacking, and
simplified the logic a bit, which should still remain mostly unchanged and
incomplete.  A complete implementation of the draft would require context
about whether it's a request or reply and possibly from the request
corresponding to the reply (!£$!@$!) so screw it.
2015-08-05 00:18:02 +01:00
Filippo Valsorda 155118a341 Reject a bad EDNS0_SUBNET family on unpack (not only on pack) 2015-08-05 00:18:02 +01:00
Filippo Valsorda 40484667f4 rewrite NSEC bitmap [un]packing to account for out-of-order 2015-08-05 00:18:02 +01:00
Filippo Valsorda 2b564cd047 UnpackDomainName: fix infinite loop where it would lower 'off'
When a pointer points to a empty name, the "return '.'" special case used to
kick in which is not pointer-aware so it would reset the parsing offset to
the pointer target

This was independently found and fixed in c13d4ee, I'm submitting this patch
anyway as it seems a bit more robust and DRY [citation needed].
2015-08-05 00:18:02 +01:00
Filippo Valsorda 77aa064ef9 packStructValue: rewrite dns:"wks" packing which was writing out of bounds 2015-08-05 00:18:02 +01:00
Filippo Valsorda 0df69faa6e packStructValue: fix a overflow in NSEC packing 2015-08-05 00:18:02 +01:00
Filippo Valsorda b5133fead4 unpackStructValue: drop rdlen, reslice msg instead 2015-08-05 00:18:02 +01:00
Filippo Valsorda 6313235fed unpackStructValue: fix a overflow in opt 2015-08-05 00:18:01 +01:00
James DeFelice e148c23156 add docs and example for DNS frame read/write decorators 2015-08-04 09:04:40 -04:00
James DeFelice e0f83dee9a add interfaces to allow packet-level inspection for pre/post processing 2015-08-04 01:17:14 -04:00
Miek Gieben 16c1d54948 Merge pull request #215 from aaronlehmann/dnssec-invalid-rrset
Check that the RRs passed to Sign and Verify form a valid RFC2181 RRSet
2015-07-29 22:13:04 +01:00
Miek Gieben 2839b93f6b merge conflict 2015-07-28 21:45:20 +01:00
Miek Gieben 3085a49d25 disallow multiple uri fragments 2015-07-28 21:44:50 +01:00
Miek Gieben 9d8cd1bfd9 Test parsing empty target 2015-07-28 07:20:54 +01:00
Miek Gieben b26019349a make dynamic updates work for URI 2015-07-27 22:22:18 +01:00
Miek Gieben 179a68fbec Some small fixes 2015-07-27 22:12:46 +01:00
Miek Gieben 14e381d23e fuzzzz 2015-07-27 21:48:46 +01:00
Miek Gieben fcf516f280 fuzzzz 2015-07-27 20:57:02 +01:00
Miek Gieben c13d4ee9cd domain names: fix compression of root-label
If the root label is compressed (which is 2 bytes, the root label
itself is only 1 byte, so why do it?), go dns incorrectly set the
offset when encountering such a name.

Fixes #234
2015-07-27 20:48:09 +01:00