Doc update for future change in TC handling
Update the comment in msg.go#L1700 about the TC bit handling Small cleanups.
This commit is contained in:
parent
bbe3422804
commit
8eb292db07
7
msg.go
7
msg.go
|
@ -29,8 +29,6 @@ var (
|
|||
ErrAuth error = &Error{err: "bad authentication"}
|
||||
// ErrBuf indicates that the buffer used it too small for the message.
|
||||
ErrBuf error = &Error{err: "buffer size too small"}
|
||||
// ErrConn indicates that a connection has both a TCP and UDP socket.
|
||||
ErrConn error = &Error{err: "conn holds both UDP and TCP connection"}
|
||||
// ErrConnEmpty indicates a connection is being uses before it is initialized.
|
||||
ErrConnEmpty error = &Error{err: "conn has no connection"}
|
||||
// ErrExtendedRcode ...
|
||||
|
@ -51,8 +49,6 @@ var (
|
|||
ErrShortRead error = &Error{err: "short read"}
|
||||
// ErrSig indicates that a signature can not be cryptographically validated.
|
||||
ErrSig error = &Error{err: "bad signature"}
|
||||
// ErrSigGen indicates a faulure to generate a signature.
|
||||
ErrSigGen error = &Error{err: "bad signature generation"}
|
||||
// ErrSOA indicates that no SOA RR was seen when doing zone transfers.
|
||||
ErrSoa error = &Error{err: "no SOA"}
|
||||
// ErrTime indicates a timing error in TSIG authentication.
|
||||
|
@ -1701,6 +1697,9 @@ func (dns *Msg) Unpack(msg []byte) (err error) {
|
|||
// an error, because technically it isn't an error. So return
|
||||
// without parsing the potentially corrupt packet and hitting an error.
|
||||
// TODO(miek): this isn't the best strategy!
|
||||
// Better stragey would be: set boolean indicating truncated message, go forth and parse
|
||||
// until we hit an error, return the message without the latest parsed rr if this boolean
|
||||
// is true.
|
||||
if dns.Truncated {
|
||||
dns.Answer = nil
|
||||
dns.Ns = nil
|
||||
|
|
Loading…
Reference in New Issue