Commit Graph

3367 Commits

Author SHA1 Message Date
Miek Gieben 3825eda935 Merge pull request #230 from sajal/master
adding TurboBytes Pulse as a user
2015-07-17 16:36:07 +01:00
Sajal Kayan 7bebd64196 adding TurboBytes Pulse as a user 2015-07-17 21:58:41 +07:00
Miek Gieben 63b32eb7eb Merge pull request #229 from rafaeljusto/invalid-idna
change function return behaviour on error
2015-07-17 13:26:08 +01:00
Rafael Dantas Justo c1abafe6ad add final dot in function comment 2015-07-17 07:17:18 -03:00
Rafael Dantas Justo 0ec31bb825 encode function should return nil when an invalid character is detected and
ToPunycode function should return an empty string when there's an invalid
domain name
2015-07-16 13:02:51 -03:00
Miek Gieben dbbb279025 Merge pull request #228 from rafaeljusto/invalid-idna
check label for invalid code points
2015-07-16 13:18:44 +01:00
Rafael Dantas Justo aab9736a4e better name for the file that store the code points list 2015-07-16 08:05:59 -03:00
Rafael Dantas Justo 4071a397d6 drop idna from names as we already are in the idn package and also avoid "else
if" when it's not necessary
2015-07-16 08:05:25 -03:00
Rafael Dantas Justo 0096e2aae0 moving logic from idna_table.go to punycode.go 2015-07-15 16:28:22 -03:00
Rafael Dantas Justo 340d862d2f check label for invalid code points according to RFC 5892, appendix B.1 2015-07-15 15:13:19 -03:00
Roland Shoemaker 3d5407e128 Fix CAA packing bug 2015-07-07 20:20:25 +01:00
Miek Gieben 3e549e2f6f And of course the test too 2015-07-03 09:34:46 +01:00
Miek Gieben 2f503031b0 Rename to ReadMsgHeader
Slightly more descriptive and remove the underscore of _DNSHeaderSize
and call is headerSize.
2015-07-03 09:31:53 +01:00
Miek Gieben 6a8b26eb31 Merge pull request #224 from asergeyev/master
Added function for lazy message reading per #222
2015-07-03 09:24:25 +01:00
Alex Sergeyev b0d6ff308e Fixed things found in code review (comments, semantics). 2015-07-02 22:42:02 -04:00
Alex Sergeyev b625f190ce Not allocating 64K buffers for reading 2015-06-29 08:06:49 -04:00
Alex Sergeyev 53dfadf090 Shortened ReadMsg using ReadMsgBytes, added a constant. 2015-06-28 20:21:37 -04:00
Alex Sergeyev 2f3bcbd506 Added function for lazy message reading per #222 2015-06-28 20:21:37 -04:00
Aaron Lehmann 2cee5e58b0 Rename isValidRRSet to IsRRset, and move it to defaults.go 2015-06-28 17:04:05 -07:00
Aaron Lehmann f605c832f0 Remove isValidRRSet check from RRSIG Sign method
Change suggested by miekg, since the caller may already know it's
passing a proper RRset.

Update unit test to call isValidRRSet directly instead of expecting Sign
to return an error for sets the fail the check.
2015-06-28 16:57:40 -07:00
Miek Gieben ad7777796e Add link to web article explaining it further 2015-06-25 07:33:30 +01:00
Miek Gieben 6da0cd2c92 CAA now also be tested in TestDynamicUpdateParsing 2015-06-19 08:23:26 +01:00
Miek Gieben 65752c4214 Merge pull request #219 from rolandshoemaker/caa
Fix CAA parsing
2015-06-19 08:20:59 +01:00
Roland Shoemaker 52647ae7a7 Address miekg's comments 2015-06-18 19:17:02 -07:00
Roland Shoemaker 020002b9e0 Switch setCAA, CAA.String to presentation format, add various encoding helpers 2015-06-17 16:06:31 -07:00
Miek Gieben db86274360 Merge pull request #221 from asergeyev/master
Minor fixes (see description)
2015-06-17 07:20:22 +01:00
Alex Sergeyev 387c041985 Changed logic around reserving wire read buffer 2015-06-16 21:21:22 -04:00
Alex Sergeyev 416c39c6e9 Removed redundant code #220 2015-06-16 19:24:38 -04:00
Roland Shoemaker 1995ce2be4 Fix unpacking 2015-06-16 13:55:19 -07:00
Roland Shoemaker e745789a1e Fix typo 2015-06-16 11:57:09 -07:00
Roland Shoemaker 522331911d Enable CAA parsing 2015-06-16 02:01:28 -07:00
Miek Gieben 7864d445e5 Merge pull request #217 from flebarbe/master
Fix crash in inIxfr when ReadMsg fails
2015-06-05 14:32:24 +01:00
Flavien Lebarbe bc2101d0db Fix crash in inIxfr when ReadMsg fails
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x5dc851]

goroutine 41 [running]:
github.com/miekg/dns.(*Transfer).inIxfr(0xc2127648d0, 0x437bcc, 0xc21678c600)
        /mnt/data/xxxxx/third-party/src/github.com/miekg/dns/xfr.go:110 +0x231
created by github.com/miekg/dns.func·073
        /mnt/data/xxxxx/third-party/src/github.com/miekg/dns/xfr.go:45 +0xf5
2015-06-05 14:59:53 +02:00
Aaron Lehmann dc56846101 Check that the RRs passed to Sign and Verify form a valid RFC2181 RRSet
Add a sanity check used by RRSig's Sign and Verify functions making sure
that the records they operate on form a valid RRSet (same name, type,
and class).

Add a unit test TestInvalidRRSet that calls RRSig's Sign and Verify
methods with invalid RRSets, and makes sure the correct error is
returned.
2015-06-04 11:13:49 -07:00
Miek Gieben bb1103f648 Merge pull request #212 from asergeyev/master
Changes for rarely-used RR types
2015-05-07 19:35:36 +01:00
Alex Sergeyev 0bc16d74c9 Added comment to commented-out testcase 2015-05-07 12:12:39 -04:00
Alex Sergeyev 32bf0823e2 Support for almost all possible ways to format HINFO record 2015-05-07 12:09:05 -04:00
Alex Sergeyev fe15681571 Fixed reversed logic. 2015-05-07 11:31:23 -04:00
Alex Sergeyev 2e9176243e Updated NSAP support according to RFC1706
New text format 0x and no more length in the object itself.
2015-05-07 10:18:47 -04:00
Alex Sergeyev d2bed60478 Fixed SSHFP parsing when multiple lines used for text representation. 2015-05-07 09:50:44 -04:00
Miek Gieben d00c3f21d4 Merge pull request #211 from miekg/tlsa
Fix TLSA parsing
2015-05-07 14:02:27 +01:00
Miek Gieben 28965350a6 Check the l.err token errors
If found return them. Not that we only return them in looping
constructs, i.e. endingTo*, in the other ones it will silently fail
still.
2015-05-07 12:47:56 +01:00
Miek Gieben 03d7235729 Add TLSA parsing tests 2015-05-07 12:47:42 +01:00
Miek Gieben 6dfba2f623 Fix off-by-one on the maxTok and maxCom check 2015-05-07 10:56:48 +01:00
Miek Gieben 8bcf792243 Playing with TLSA records 2015-05-07 07:42:55 +01:00
Miek Gieben 3331c2fad9 Merge commit '627287e675fb79f57928f77fbfae24abe15ed58b' into tlsa 2015-05-07 07:31:57 +01:00
Miek Gieben 031d041ced Merge pull request #209 from michaelharo/client
Cleanup Client.exchange
2015-05-07 07:28:34 +01:00
Alex Sergeyev 627287e675 Issue with TLSA parsing identified 2015-05-06 23:25:33 -04:00
Miek Gieben af747277f5 Merge pull request #208 from michaelharo/checkid
Check that the query ID matches the answer ID.
2015-05-06 09:14:39 +01:00
Michael Haro 32448f39cd Cleanup Client.exchange
Make Client's exchange function easier to read by moving timeout logic
into separate functions.

Start the timers closer to where they're used so that time from other
logic doesn't impact the deadlines.
2015-05-05 23:23:53 -07:00