* Refactor net.PacketConn checks into helper function
* Only treat a *net.UnixConn of unixgram as a packet conn
* Handle wrapped net.Conn types in isPacketConn
* Use Error instead of Fatal where appropriate in TestIsPacketConn
* Fix un/packing of EDNS0 TCP keepalive extension
The current code is assuming the OPT code and length are part of the
data passed to the unpacker and that it should be appenedded during
packing while those fields are parsed by the caller.
This change fixes the parsing and make sure a request with a keepalive
won't fail.
* added tests for EDNS0_TCP_KEEPALIVE pack/unpack
* mark Length as deprecated
* removed named returns
* restored String
Co-authored-by: Olivier Poitrey <rs@rhapsodyk.net>
* Per RFC 8945 5.3.2, responses with BADKEY and BADSIG errors must not be signed.
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
* refactor to remove else block
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
* skip signing only for BADKEY and BADSIG
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
* Fix go generate missing required go.mod entry
There were no non-excluded files importing golang.org/x/tools so it's
require was missing from go.mod. This caused the go run commands
invoked by go generate to fail.
tools.go is currently the recommended way to force non-build
dependencies to be retained by the go mod commands. If that changes in
the future, we can update then. As nothing from the import is actually
used, it won't impact anyone's build at all (except requiring an extra
download by the go tool which is unavoidable).
Pulling in the @master version of golang.org/x/tools (which doesn't yet
have a stable release version) also updates a number of other
dependencies, but not quite to latest, so while I'm here just update
them all.
* Add explanatory comment and build tag to tools.go
Make it more obvious that these two lists (const, and case) need to be
in sync.
Also sort the list to match the const sorting.
Signed-off-by: Miek Gieben <miek@miek.nl>
When decoding a HIP resource record, 'base64.StdEncoding.DecodedLen' can return a length larger than the length of the decoded public key. This change decodes the public key and retrieves the correct length. In our tests, the public key length was being set to 33, instead of 32. Below is our offending resource record:
'23b5993f649c0827.a.b.c. 3600 IN HIP 5 200100100020001523B5993F649C0827 Cm6k4jhir9YYoKq9JDqD3Ob1hBfCuwbWam1igFPhkGg='
The existing of the file signifies it needs to run, so now it errors
that there is nothing to run (everything is commented out).
Remove the entire file.
Signed-off-by: Miek Gieben <miek@miek.nl>
Go 1.11 was a long time ago, so rename the reuseport go files to
something more sane. Contemplated _unix, or _posix but that didn't
really cut it. Went with reuseport and no_reuseport.
Also bump go.mod to 1.14
Signed-off-by: Miek Gieben <miek@miek.nl>
* Fix copy() in SVCBIPv4Hint and SVCBIPv6Hint
The problem with the current implementation is that it is not a real deep copy,
it points to the same base arrays behind the slices. This was causing some
issues in real-life application.
* Address review comments
* Remove HmacMD5 from the documention
The aglo is deprecated.
Signed-off-by: Miek Gieben <miek@miek.nl>
* bump to sha256
Signed-off-by: Miek Gieben <miek@miek.nl>
* Bump go versions in .github/workflows/go.yml
These are very out of date and it's causing persistent failures in the
fuzz CI step.
* Remove GOPATH=$GOROOT assignment
go1.16 shows a warning:
"warning: GOPATH set to GOROOT (/opt/hostedtoolcache/go/1.16.0/x64) has no effect"
* Send DNS query in one packet when using TCP/TLS
* fix review comments
* Removed net.Buffers
* Added unit-tests for writing messages over TCP in one go
* Update Truncate doc with compress behaviour
This is a documentation update to highlight the behaviour of Truncate, which will reset dns.Compress to false when the message fits in the requested size without truncation, and make it the caller responsibility to set it back to true if they wish to compress, regardless of fitting, uncompressed, in the requested message size in the first place or not.
Fixes#1216
* address comments
* d/Note that/
* s/reset/set/
* s/caller/caller's/
* removed backticks
* regardless of size
Tom Thorogood
JeremyRand
bshea3
Mark
Miek Gieben
Andrey Meshkov
Chris O'Haver
Konstantine
Tom Sellers
Alexandru Ionut Tripon
Johan Knutzen
Manabu Sonoda
Aveline
Malte Granderath
joseph-stanton-ax
Fredrik Lönnegren
Daniel Tang
cesarkuroiwa
madestro
Josh Soref
Shubhendra Singh Chauhan
R+
Nikolay Nikolaev
Andrey Meshkov
unknowndev233
chantra