Commit Graph

2957 Commits

Author SHA1 Message Date
Miek Gieben 10dc4b971d Merge pull request #117 from asergeyev/defaultmux
Addressed #115 (default mux should be cleaned after tests)
2014-08-30 14:49:07 +01:00
Alex Sergeyev 3489112d72 Addressed #115 (default mux should be cleaned after tests) 2014-08-30 09:45:30 -04:00
Miek Gieben 1fde15f6f3 Merge pull request #116 from asergeyev/master
Removed Goshed from Run???TestServer.
2014-08-30 14:42:49 +01:00
Alex Sergeyev de77e9d14d Removed Goshed from RunXXXTestServer and...
only used it for shutdown tests where it makes sense.
2014-08-30 09:35:54 -04:00
Miek Gieben ebc5489482 Fix datarace in Start/Shutdown
Add mutex and guard a 'started' boolean as well as the stopUDP
and tcpTCP channels so that 'go test -race' does not trigger.

Closes #111, closes #114
2014-08-30 10:34:44 +01:00
Miek Gieben 06fc321c2c fmt 2014-08-30 08:45:10 +01:00
Miek Gieben 5fd5c6d9eb And actually fix the parsing 2014-08-30 08:44:16 +01:00
Miek Gieben cbb9881e96 Parse dynamic update RR in presentation format
Don't panic when encountering dynamic update RRs in zonefiles.
There are some other failure cases when parsing, those will be
fixed in subsequent commits.

Closes #110
2014-08-30 07:34:05 +01:00
Miek Gieben a2ad8f8ac5 Merge pull request #113 from asergeyev/master
No timeouts in tests
2014-08-30 07:19:21 +01:00
Alex Sergeyev fce659ba46 Restored code when shutdown needs an exchange...
Clients sents NULL-packet to server which helps to avoid
timeout. Timeout is still possible to encounter.
Shutdown will likely report error for those cases.
2014-08-29 14:27:53 -04:00
Alex Sergeyev c618657d9b Dealt with race condition detector warnings:
* stopped obvious race condition with replacing handler in
  ServingLargeResponses test
* lowered probability of other race conditions with test code
  while test server is yet activating
* fixed errmessage in Shutdown
2014-08-29 14:10:05 -04:00
Alex Sergeyev ef07b9a69a Following up in introducing getReadTimeout() 2014-08-29 12:26:23 -04:00
Alex Sergeyev f735bb9dcb Changed how shutdown works...
Now stopXXX event will stop any reading on currently open
socket and terminate reading loop. No special client/server
message is required anymore.
2014-08-29 12:24:11 -04:00
Alex Sergeyev e7a401841e Fixed client tests and removed TODO about timeouts 2014-08-29 08:59:19 -04:00
Alex Sergeyev 87f8764f43 Added a comment about shutdown tests 2014-08-29 08:37:32 -04:00
Alex Sergeyev 32d6e5396e Continued removing Sleeping tests:
* incorporated @miekg suggestions on switch vs if
* for now moved reaction to stopXXX channel messages until
  after the packet is responded to avoid client timeout in
  Shutdown (causing 2 sec. hanged thread)

Still not great how the abort logic is implemented....
2014-08-29 08:31:27 -04:00
Miek Gieben f6c7c65fc4 Merge branch 'master' of github.com:miekg/dns 2014-08-29 09:42:53 +00:00
Miek Gieben cfa561ed85 Add TestDynamicUpdateParsing test 2014-08-29 09:42:43 +00:00
Alex Sergeyev 4b21f37064 Proposed way of creating no-timeout tests and...
... fix for Server.Shutdown() function.
2014-08-28 23:11:49 -04:00
Miek Gieben 28dc2fa7be Merge pull request #109 from asergeyev/master
Some tokens only worked in upper case, fixing that.
2014-08-28 18:46:37 +01:00
Alex Sergeyev 05bec3968a Addressed cases when tokenUpper makes sense to be used. 2014-08-28 13:34:00 -04:00
Alex Sergeyev 1959cc8421 Added tests to support mixed case Type and Class 2014-08-28 13:05:05 -04:00
Alex Sergeyev 9c4dca35d5 Removed unnecessary toUpper. 2014-08-28 12:59:54 -04:00
Alex Sergeyev 84d9ad0a39 Fixed typo in "tokens" 2014-08-28 12:59:54 -04:00
Alex Sergeyev 476d122030 Changed test for lowercase tokens; improved code:
* for cases if $ORIGIN or $TTL are used in mixed case
* changed test name too
2014-08-28 12:59:54 -04:00
Alex Sergeyev d1ea8497ad Added couple failure tests for lowercase class/type 2014-08-28 12:59:54 -04:00
Alex Sergeyev 66342f4ea2 Added test to verify RRSIG type covered in mixed case. 2014-08-28 12:59:54 -04:00
Alex Sergeyev 755a8483b6 Committing @miekg patch from gist.
https://gist.github.com/miekg/f1b1fe6dba7d6b088eec
2014-08-28 12:59:54 -04:00
Alex Sergeyev e9bffe6796 Added lowercase test strings with RR class omitted 2014-08-28 12:59:54 -04:00
Alex Sergeyev 0df460c0fa Added lowercase RR tests where TTL is in play too. 2014-08-28 12:59:54 -04:00
Alex Sergeyev f40b966c47 Added lowercase RRClass and RRType tests per #108.
... need to add RRSIG covering type lowercased later.
2014-08-28 12:59:54 -04:00
Miek Gieben 2127b822dd Add comment about Systemd 2014-08-28 07:54:23 +00:00
Miek Gieben 53a11d9163 better err message 2014-08-27 22:09:21 +01:00
Miek Gieben cd4dac5f59 update README 2014-08-23 07:52:34 +01:00
Miek Gieben 8fecf17714 Check that off <= lenmsg
Defense in depth, this should happen, but it happens... So check
for it and return an error.

Maybe (there is no testcase) fixes #106
2014-08-23 07:43:00 +01:00
Miek Gieben 34f5a12bfc Don't crash on emtpy string in compressionLenSearch
Fixes #105
2014-08-22 08:46:24 +00:00
Miek Gieben 9f5fcf8459 Add extra length test for issue #105 2014-08-22 08:15:35 +01:00
Miek Gieben f0bd4137e2 Make Shutdown return error
This will be handy in feature, so that we can add a 1 second
timeout and then return failure.
2014-08-20 15:12:59 +00:00
Miek Gieben 01bbcbef60 Update documentation for Shutdown.
This completes issue #101.
Fixes #101
2014-08-19 22:08:13 +01:00
Miek Gieben eed2b9aeec Fix Shutdown 2014-08-19 21:56:37 +01:00
Miek Gieben f912994258 Don't relay on deadline to stop the server.
We just send ourselves an UDP or TCP packet so that the listener fails
through and picks up the quit bool send on the channel.
2014-08-19 21:46:00 +01:00
Miek Gieben 263a337674 Change test ports, stuff might still be running 2014-08-19 09:33:50 +00:00
Miek Gieben 6c631cd4ff Implement Shutdown()
This is working for TCP, but for UDP the Read does not honor the
deadline settings.
2014-08-19 09:25:41 +00:00
Miek Gieben f5fe400c53 Lowercase all test output.
Add Shutdown tests as well
2014-08-19 08:39:04 +00:00
Miek Gieben 292c925c9f update documentation 2014-08-18 22:21:02 +01:00
Miek Gieben 0d300b1fce Add deadline to the listeners
Call this deadline to the listener will timeout and we will get to
so if the server should shutdown.
2014-08-18 22:14:29 +01:00
Miek Gieben f3a6c86462 Implement Shutdown() call
And fix some tests to call Fatal().
2014-08-18 22:06:29 +01:00
Miek Gieben 6cf24a5637 Add a Shutdown method to server.
Allow gracefull shutdown of a server.
2014-08-18 20:30:10 +01:00
Miek Gieben eb2d26cb96 Remove Pool from server.
A noop for some time, remove it.
2014-08-18 20:29:54 +01:00
Miek Gieben 4d3dac9c36 Add the OPENPGPKEY RR. 2014-08-14 09:18:08 +01:00