Spelling (#1222)
* spelling: artifacts Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: encoding Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: exponent Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: ignoring Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: implemented Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: implements Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: next Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: numeric Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: previous Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: positions Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: presentation Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: resetting Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: stringifying Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: subsequent Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: validated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
parent
2f14d104f3
commit
883641f4a9
|
@ -1,7 +1,7 @@
|
||||||
# Makefile for releasing.
|
# Makefile for releasing.
|
||||||
#
|
#
|
||||||
# The release is controlled from version.go. The version found there is
|
# The release is controlled from version.go. The version found there is
|
||||||
# used to tag the git repo, we're not building any artifects so there is nothing
|
# used to tag the git repo, we're not building any artifacts so there is nothing
|
||||||
# to upload to github.
|
# to upload to github.
|
||||||
#
|
#
|
||||||
# * Up the version in version.go
|
# * Up the version in version.go
|
||||||
|
|
|
@ -379,7 +379,7 @@ func Dial(network, address string) (conn *Conn, err error) {
|
||||||
func ExchangeContext(ctx context.Context, m *Msg, a string) (r *Msg, err error) {
|
func ExchangeContext(ctx context.Context, m *Msg, a string) (r *Msg, err error) {
|
||||||
client := Client{Net: "udp"}
|
client := Client{Net: "udp"}
|
||||||
r, _, err = client.ExchangeContext(ctx, m, a)
|
r, _, err = client.ExchangeContext(ctx, m, a)
|
||||||
// ignorint rtt to leave the original ExchangeContext API unchanged, but
|
// ignoring rtt to leave the original ExchangeContext API unchanged, but
|
||||||
// this function will go away
|
// this function will go away
|
||||||
return r, err
|
return r, err
|
||||||
}
|
}
|
||||||
|
|
|
@ -500,7 +500,7 @@ func (rr *RRSIG) ValidityPeriod(t time.Time) bool {
|
||||||
return ti <= utc && utc <= te
|
return ti <= utc && utc <= te
|
||||||
}
|
}
|
||||||
|
|
||||||
// Return the signatures base64 encodedig sigdata as a byte slice.
|
// Return the signatures base64 encoding sigdata as a byte slice.
|
||||||
func (rr *RRSIG) sigBuf() []byte {
|
func (rr *RRSIG) sigBuf() []byte {
|
||||||
sigbuf, err := fromBase64([]byte(rr.Signature))
|
sigbuf, err := fromBase64([]byte(rr.Signature))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|
2
edns.go
2
edns.go
|
@ -525,7 +525,7 @@ func (e *EDNS0_N3U) String() string {
|
||||||
}
|
}
|
||||||
func (e *EDNS0_N3U) copy() EDNS0 { return &EDNS0_N3U{e.Code, e.AlgCode} }
|
func (e *EDNS0_N3U) copy() EDNS0 { return &EDNS0_N3U{e.Code, e.AlgCode} }
|
||||||
|
|
||||||
// EDNS0_EXPIRE implementes the EDNS0 option as described in RFC 7314.
|
// EDNS0_EXPIRE implements the EDNS0 option as described in RFC 7314.
|
||||||
type EDNS0_EXPIRE struct {
|
type EDNS0_EXPIRE struct {
|
||||||
Code uint16 // Always EDNS0EXPIRE
|
Code uint16 // Always EDNS0EXPIRE
|
||||||
Expire uint32
|
Expire uint32
|
||||||
|
|
|
@ -78,7 +78,7 @@ func TestPackDataOpt(t *testing.T) {
|
||||||
// "0\x00\v\x00#\b00000\x00\x00\x00\x00\x00\x1a000" +
|
// "0\x00\v\x00#\b00000\x00\x00\x00\x00\x00\x1a000" +
|
||||||
// "000\x00\x00\x00\x00\x1a000000\x00\x00\x00\x00\x1a0" +
|
// "000\x00\x00\x00\x00\x1a000000\x00\x00\x00\x00\x1a0" +
|
||||||
// "00000\x00\v00\a0000000\x00"
|
// "00000\x00\v00\a0000000\x00"
|
||||||
// That byte sequence, when Unpack() and subsequential Pack() created a
|
// That byte sequence, when Unpack() and subsequent Pack() created a
|
||||||
// panic: runtime error: slice bounds out of range
|
// panic: runtime error: slice bounds out of range
|
||||||
// which was attributed to the fact that NSEC RR length computation was different (and smaller)
|
// which was attributed to the fact that NSEC RR length computation was different (and smaller)
|
||||||
// then when within packDataNsec.
|
// then when within packDataNsec.
|
||||||
|
@ -111,7 +111,7 @@ func TestCrashNSEC(t *testing.T) {
|
||||||
// "0000\x00\x00000000\x00\x00200000" +
|
// "0000\x00\x00000000\x00\x00200000" +
|
||||||
// "0\x00\v0000\x00\x00#\x0300\x00\x00\x00\x1a000" +
|
// "0\x00\v0000\x00\x00#\x0300\x00\x00\x00\x1a000" +
|
||||||
// "000\x00\v00\x0200\x00\x03000\x00"
|
// "000\x00\v00\x0200\x00\x03000\x00"
|
||||||
// That byte sequence, when Unpack() and subsequential Pack() created a
|
// That byte sequence, when Unpack() and subsequent Pack() created a
|
||||||
// panic: runtime error: slice bounds out of range
|
// panic: runtime error: slice bounds out of range
|
||||||
// which was attributed to the fact that NSEC3 RR length computation was
|
// which was attributed to the fact that NSEC3 RR length computation was
|
||||||
// different (and smaller) then within NSEC3.pack (which relies on
|
// different (and smaller) then within NSEC3.pack (which relies on
|
||||||
|
|
|
@ -94,7 +94,7 @@ func TestNextLabel(t *testing.T) {
|
||||||
for s, i := range nexts {
|
for s, i := range nexts {
|
||||||
x, ok := NextLabel(s.string, s.int)
|
x, ok := NextLabel(s.string, s.int)
|
||||||
if i != x {
|
if i != x {
|
||||||
t.Errorf("label should be %d, got %d, %t: nexting %d, %s", i, x, ok, s.int, s.string)
|
t.Errorf("label should be %d, got %d, %t: next %d, %s", i, x, ok, s.int, s.string)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -123,7 +123,7 @@ func TestPrevLabel(t *testing.T) {
|
||||||
for s, i := range prever {
|
for s, i := range prever {
|
||||||
x, ok := PrevLabel(s.string, s.int)
|
x, ok := PrevLabel(s.string, s.int)
|
||||||
if i != x {
|
if i != x {
|
||||||
t.Errorf("label should be %d, got %d, %t: preving %d, %s", i, x, ok, s.int, s.string)
|
t.Errorf("label should be %d, got %d, %t: previous %d, %s", i, x, ok, s.int, s.string)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
2
msg.go
2
msg.go
|
@ -742,7 +742,7 @@ func (dns *Msg) packBufferWithCompressionMap(buf []byte, compression compression
|
||||||
}
|
}
|
||||||
|
|
||||||
// Set extended rcode unconditionally if we have an opt, this will allow
|
// Set extended rcode unconditionally if we have an opt, this will allow
|
||||||
// reseting the extended rcode bits if they need to.
|
// resetting the extended rcode bits if they need to.
|
||||||
if opt := dns.IsEdns0(); opt != nil {
|
if opt := dns.IsEdns0(); opt != nil {
|
||||||
opt.SetExtendedRcode(uint16(dns.Rcode))
|
opt.SetExtendedRcode(uint16(dns.Rcode))
|
||||||
} else if dns.Rcode > 0xF {
|
} else if dns.Rcode > 0xF {
|
||||||
|
|
|
@ -266,7 +266,7 @@ func testTXTRRQuick(t *testing.T) {
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
if len(rdata) == 0 {
|
if len(rdata) == 0 {
|
||||||
// string'ing won't produce any data to parse
|
// stringifying won't produce any data to parse
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
rrString := rr.String()
|
rrString := rr.String()
|
||||||
|
@ -1671,10 +1671,10 @@ func TestParseBadSVCB(t *testing.T) {
|
||||||
`1 . key065534`, // key can't be padded
|
`1 . key065534`, // key can't be padded
|
||||||
`1 . key65534="f`, // unterminated value
|
`1 . key65534="f`, // unterminated value
|
||||||
`1 . key65534="`, // unterminated value
|
`1 . key65534="`, // unterminated value
|
||||||
`1 . key65534=\2`, // invalid numberic escape
|
`1 . key65534=\2`, // invalid numeric escape
|
||||||
`1 . key65534=\24`, // invalid numberic escape
|
`1 . key65534=\24`, // invalid numeric escape
|
||||||
`1 . key65534=\256`, // invalid numberic escape
|
`1 . key65534=\256`, // invalid numeric escape
|
||||||
`1 . key65534=\`, // invalid numberic escape
|
`1 . key65534=\`, // invalid numeric escape
|
||||||
`1 . key65534=""alpn`, // zQuote ending needs whitespace
|
`1 . key65534=""alpn`, // zQuote ending needs whitespace
|
||||||
`1 . key65534="a"alpn`, // zQuote ending needs whitespace
|
`1 . key65534="a"alpn`, // zQuote ending needs whitespace
|
||||||
`1 . ipv6hint=1.1.1.1`, // not ipv6
|
`1 . ipv6hint=1.1.1.1`, // not ipv6
|
||||||
|
|
|
@ -6,7 +6,7 @@ import "strings"
|
||||||
// RFC 6895. This allows one to experiment with new RR types, without requesting an
|
// RFC 6895. This allows one to experiment with new RR types, without requesting an
|
||||||
// official type code. Also see dns.PrivateHandle and dns.PrivateHandleRemove.
|
// official type code. Also see dns.PrivateHandle and dns.PrivateHandleRemove.
|
||||||
type PrivateRdata interface {
|
type PrivateRdata interface {
|
||||||
// String returns the text presentaton of the Rdata of the Private RR.
|
// String returns the text presentation of the Rdata of the Private RR.
|
||||||
String() string
|
String() string
|
||||||
// Parse parses the Rdata of the private RR.
|
// Parse parses the Rdata of the private RR.
|
||||||
Parse([]string) error
|
Parse([]string) error
|
||||||
|
|
2
scan.go
2
scan.go
|
@ -1352,7 +1352,7 @@ func stringToNodeID(l lex) (uint64, *ParseError) {
|
||||||
if len(l.token) < 19 {
|
if len(l.token) < 19 {
|
||||||
return 0, &ParseError{l.token, "bad NID/L64 NodeID/Locator64", l}
|
return 0, &ParseError{l.token, "bad NID/L64 NodeID/Locator64", l}
|
||||||
}
|
}
|
||||||
// There must be three colons at fixes postitions, if not its a parse error
|
// There must be three colons at fixes positions, if not its a parse error
|
||||||
if l.token[4] != ':' && l.token[9] != ':' && l.token[14] != ':' {
|
if l.token[4] != ':' && l.token[9] != ':' && l.token[14] != ':' {
|
||||||
return 0, &ParseError{l.token, "bad NID/L64 NodeID/Locator64", l}
|
return 0, &ParseError{l.token, "bad NID/L64 NodeID/Locator64", l}
|
||||||
}
|
}
|
||||||
|
|
|
@ -239,7 +239,7 @@ func TestServeNotImplemented(t *testing.T) {
|
||||||
c := new(Client)
|
c := new(Client)
|
||||||
m := new(Msg)
|
m := new(Msg)
|
||||||
|
|
||||||
// Test that Opcode is like the unchanged from request Opcode and that Rcode is set to NotImplemnented
|
// Test that Opcode is like the unchanged from request Opcode and that Rcode is set to NotImplemented
|
||||||
m.SetQuestion("example.com.", TypeTXT)
|
m.SetQuestion("example.com.", TypeTXT)
|
||||||
m.Opcode = opcode
|
m.Opcode = opcode
|
||||||
r, _, err := c.Exchange(m, addrstr)
|
r, _, err := c.Exchange(m, addrstr)
|
||||||
|
@ -1031,7 +1031,7 @@ func TestServerRoundtripTsig(t *testing.T) {
|
||||||
// *Msg r has an TSIG record and it was validated
|
// *Msg r has an TSIG record and it was validated
|
||||||
m.SetTsig("test.", HmacSHA256, 300, time.Now().Unix())
|
m.SetTsig("test.", HmacSHA256, 300, time.Now().Unix())
|
||||||
} else {
|
} else {
|
||||||
// *Msg r has an TSIG records and it was not valided
|
// *Msg r has an TSIG records and it was not validated
|
||||||
t.Errorf("invalid TSIG: %v", status)
|
t.Errorf("invalid TSIG: %v", status)
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in New Issue