community
/
rclone
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

azureblob: remove 100MB upper limit on chunk_size as it is no longer needed

This commit is contained in:
Nick Craig-Wood 2021-11-12 12:12:20 +00:00
parent 4454b3e1ae
commit fbc4c4ad9a
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backend/azureblob/azureblob.go
View File

@ -50,7 +50,6 @@ const (
timeFormatOut = "2006-01-02T15:04:05.000000000Z07:00" timeFormatOut = "2006-01-02T15:04:05.000000000Z07:00"
storageDefaultBaseURL = "blob.core.windows.net" storageDefaultBaseURL = "blob.core.windows.net"
defaultChunkSize = 4 * fs.Mebi defaultChunkSize = 4 * fs.Mebi
maxChunkSize = 100 * fs.Mebi
defaultAccessTier = azblob.AccessTierNone defaultAccessTier = azblob.AccessTierNone
maxTryTimeout = time.Hour * 24 * 365 //max time of an azure web request response window (whether or not data is flowing) maxTryTimeout = time.Hour * 24 * 365 //max time of an azure web request response window (whether or not data is flowing)
// Default storage account, key and blob endpoint for emulator support, // Default storage account, key and blob endpoint for emulator support,
@ -133,7 +132,7 @@ msi_client_id, or msi_mi_res_id parameters.`,
Advanced: true, Advanced: true,
}, { }, {
Name: "chunk_size", Name: "chunk_size",
Help: `Upload chunk size (<= 100 MiB). Help: `Upload chunk size.
Note that this is stored in memory and there may be up to Note that this is stored in memory and there may be up to
"--transfers" * "--azureblob-upload-concurrency" chunks stored at once "--transfers" * "--azureblob-upload-concurrency" chunks stored at once
@ -437,9 +436,6 @@ func checkUploadChunkSize(cs fs.SizeSuffix) error {
if cs < minChunkSize { if cs < minChunkSize {
return fmt.Errorf("%s is less than %s", cs, minChunkSize) return fmt.Errorf("%s is less than %s", cs, minChunkSize)
} }
if cs > maxChunkSize {
return fmt.Errorf("%s is greater than %s", cs, maxChunkSize)
}
return nil return nil
} }

10
backend/azureblob/azureblob_test.go
View File

@ -17,12 +17,10 @@ import (
// TestIntegration runs integration tests against the remote // TestIntegration runs integration tests against the remote
func TestIntegration(t *testing.T) { func TestIntegration(t *testing.T) {
fstests.Run(t, &fstests.Opt{ fstests.Run(t, &fstests.Opt{
RemoteName: "TestAzureBlob:", RemoteName: "TestAzureBlob:",
NilObject: (*Object)(nil), NilObject: (*Object)(nil),
TiersToTest: []string{"Hot", "Cool"}, TiersToTest: []string{"Hot", "Cool"},
ChunkedUpload: fstests.ChunkedUploadConfig{ ChunkedUpload: fstests.ChunkedUploadConfig{},
MaxChunkSize: maxChunkSize,
},
}) })
} }