From c968c3e41cf71896f50f6b4a5c3cc5ffd5e7fa35 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Wed, 10 Nov 2021 15:40:36 +0000 Subject: [PATCH] build: raise minimum go version to go1.15 This was necessary because go1.14 seems to have a modules related bug which means it tries to build modules even though the uses of them are all disabled with build constraints. This seems to be fixed in go1.15. --- .github/workflows/build.yml | 8 +------- docs/content/install.md | 2 +- fs/versioncheck.go | 8 ++++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b52bc7fb4..06095ea3e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,7 +25,7 @@ jobs: strategy: fail-fast: false matrix: - job_name: ['linux', 'mac_amd64', 'mac_arm64', 'windows_amd64', 'windows_386', 'other_os', 'go1.14', 'go1.15', 'go1.16'] + job_name: ['linux', 'mac_amd64', 'mac_arm64', 'windows_amd64', 'windows_386', 'other_os', 'go1.15', 'go1.16'] include: - job_name: linux @@ -83,12 +83,6 @@ jobs: compile_all: true deploy: true - - job_name: go1.14 - os: ubuntu-latest - go: '1.14.x' - quicktest: true - racequicktest: true - - job_name: go1.15 os: ubuntu-latest go: '1.15.x' diff --git a/docs/content/install.md b/docs/content/install.md index ac82708fe..4513860ce 100644 --- a/docs/content/install.md +++ b/docs/content/install.md @@ -190,7 +190,7 @@ kill %1 ## Install from source ## -Make sure you have at least [Go](https://golang.org/) go1.14 +Make sure you have at least [Go](https://golang.org/) go1.15 installed. [Download go](https://golang.org/dl/) if necessary. The latest release is recommended. Then diff --git a/fs/versioncheck.go b/fs/versioncheck.go index 29bbfd8e2..03a406a12 100644 --- a/fs/versioncheck.go +++ b/fs/versioncheck.go @@ -1,8 +1,8 @@ -//go:build !go1.14 -// +build !go1.14 +//go:build !go1.15 +// +build !go1.15 package fs -// Upgrade to Go version 1.14 to compile rclone - latest stable go +// Upgrade to Go version 1.15 to compile rclone - latest stable go // compiler recommended. -func init() { Go_version_1_14_required_for_compilation() } +func init() { Go_version_1_15_required_for_compilation() }