From b5857f0bf82238ea0b4a0a63825d3dd9c893668e Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Sat, 25 Nov 2023 18:24:20 +0000 Subject: [PATCH] smb: fix modtime of multithread uploads by setting PartialUploads Before this change PartialUploads was not set. This is clearly wrong since incoming files are visible on the smb server. Setting PartialUploads fixes the multithread upload modtime problem as it uses the PartialUploads flag as an indication that it needs to set the modtime explicitly. This problem was detected by the new TestMultithreadCopy integration tests Fixes #7411 --- backend/smb/smb.go | 1 + 1 file changed, 1 insertion(+) diff --git a/backend/smb/smb.go b/backend/smb/smb.go index 704c998f9..37ac06554 100644 --- a/backend/smb/smb.go +++ b/backend/smb/smb.go @@ -177,6 +177,7 @@ func NewFs(ctx context.Context, name, root string, m configmap.Mapper) (fs.Fs, e CaseInsensitive: opt.CaseInsensitive, CanHaveEmptyDirectories: true, BucketBased: true, + PartialUploads: true, }).Fill(ctx, f) f.pacer = fs.NewPacer(ctx, pacer.NewDefault(pacer.MinSleep(minSleep), pacer.MaxSleep(maxSleep), pacer.DecayConstant(decayConstant)))