From 3f7abd278d6f6f55167be9437a108b8373ede157 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Wed, 27 Dec 2023 16:19:31 +0000 Subject: [PATCH] googlephotos: fix nil pointer exception when batch failed This was a simple error check that was missing. Interestingly the errcheck linter did not spot this. See: https://forum.rclone.org/t/invalid-memory-address-or-nil-pointer-dereference-error-when-copy-to-google-photos/43634/ --- backend/googlephotos/googlephotos.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/backend/googlephotos/googlephotos.go b/backend/googlephotos/googlephotos.go index df031b606..0b0290d3a 100644 --- a/backend/googlephotos/googlephotos.go +++ b/backend/googlephotos/googlephotos.go @@ -1143,6 +1143,9 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op info = results[0] } } + if err != nil { + return fmt.Errorf("failed to commit batch: %w", err) + } o.setMetaData(info)