community
/
rclone
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

flags: improve error message when reading environment vars #4888 

The message now includes the flag name to help the user work out what
is happening.

    Invalid value for environment variable "RCLONE_VERSION" when setting default
    for --version: strconv.ParseBool: parsing "yes": invalid syntax
This commit is contained in:
Nick Craig-Wood 2020-12-28 12:26:23 +00:00
parent 629c0d0f65
commit 060642ad14
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/config/flags/flags.go
View File

@ -19,13 +19,13 @@ func setDefaultFromEnv(flags *pflag.FlagSet, name string) {
if found {
flag := flags.Lookup(name)
if flag == nil {
log.Fatalf("Couldn't find flag %q", name)
log.Fatalf("Couldn't find flag --%q", name)
}
err := flag.Value.Set(newValue)
if err != nil {
log.Fatalf("Invalid value for environment variable %q: %v", key, err)
log.Fatalf("Invalid value for environment variable %q when setting default for --%s: %v", key, name, err)
}
fs.Debugf(nil, "Set default for %q from %q to %q (%v)", name, key, newValue, flag.Value)
fs.Debugf(nil, "Set default for --%q from %q to %q (%v)", name, key, newValue, flag.Value)
flag.DefValue = newValue
}
}