community
/
gitea
3
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
gitea/modules/structs
History
Giteabot 203fe2841d
Fix `Permission` in API returned repository struct (#25388) (#25441) 
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
 		2023-06-22 17:01:42 +02:00
..
activity.go Add activity feeds API (#23494) 2023-04-04 21:35:31 +08:00
activitypub.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
admin_user.go Allow custom "created" timestamps in user creation API (#22549) 2023-02-16 10:32:01 -06:00
attachment.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
commit_status.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
cron.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
doc.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fork.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
git_blob.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
git_hook.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go New webhook trigger for receiving Pull Request review requests (#24481) 2023-05-24 22:06:27 -04:00
issue.go Add the ability to pin Issues (#24406) 2023-05-25 15:17:19 +02:00
issue_comment.go Add API management for issue/pull and comment attachments (#21783) 2022-12-09 14:35:56 +08:00
issue_label.go Add API for Label templates (#24602) 2023-05-23 18:10:23 +08:00
issue_milestone.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_reaction.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_stopwatch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_tracked_time.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
lfs_lock.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mirror.go Add `sync_on_commit` option for push mirrors api (#22271) 2022-12-30 19:22:51 +08:00
miscellaneous.go Add API for gitignore templates (#22783) 2023-04-27 11:51:20 +08:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
notifications.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org.go Fix Org edit page bugs: renaming detection, maxlength (#24161) 2023-04-17 11:35:57 -04:00
org_member.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org_team.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
package.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pull.go Add the ability to pin Issues (#24406) 2023-05-25 15:17:19 +02:00
pull_review.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
release.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Fix `Permission` in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
repo_branch.go Supports wildcard protected branch (#20825) 2023-01-16 16:00:22 +08:00
repo_collaborator.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_commit.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_file.go fix swagger documentation for multiple files API endpoint (#25110) 2023-06-07 23:49:58 +08:00
repo_key.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_note.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_refs.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_tag.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_topic.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_tree.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_watch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_wiki.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
settings.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
status.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
task.go Make repo migration cancelable and fix various bugs (#24605) 2023-05-11 08:25:46 +00:00
user.go add user rename endpoint to admin api (#22789) 2023-03-14 03:45:21 -04:00
user_app.go Add scopes to API to create token and display them (#22989) 2023-02-20 15:28:44 -06:00
user_email.go add admin API email endpoints (#22792) 2023-03-14 03:54:40 -04:00
user_gpgkey.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_key.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
visible_type.go change org_type.go to visible_type.go and fix the notes (#22752) 2023-02-09 06:40:34 +00:00