community
/
gitea
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
gitea/services/actions
History
Brad Nabholz 950c93a66a
Actions: Use default branch as ref when a branch/tag delete occurs (#23910) 
Currently using the tip of main
(2c585d62a4) and when deleting a branch
(and presumably tag, but not tested), no workflows with `on: [delete]`
are being triggered. The runner isn't being notified about them. I see
this in the gitea log:

`2023/04/04 04:29:36 ...s/notifier_helper.go:102:Notify() [E] an error
occurred while executing the NotifyDeleteRef actions method:
gitRepo.GetCommit: object does not exist [id: test, rel_path: ]`

Understandably the ref has already been deleted and so `GetCommit`
fails. Currently at
https://github.com/go-gitea/gitea/blob/main/services/actions/notifier_helper.go#L130,
if the ref is an empty string it falls back to the default branch name.
This PR also checks if it is a `HookEventDelete` and does the same.
Currently `${{ github.ref }}` would be equivalent to the deleted branch
(if `notify()` succeded), but this PR allows `notify()` to proceed and
also aligns it with the GitHub Actions behavior at
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#delete:

`$GITHUB_REF` / `${{ github.ref }}` => Default branch (main/master)
`$GITHUB_SHA` / `${{ github.sha }}` => Last commit on default branch

If the user needs the name of the deleted branch (or tag), it is
available as `${{ github.event.ref }}`.

There appears to be no way for the user to get the tip commit SHA of the
deleted branch (GitHub does not do this either).

N.B. there may be other conditions other than `HookEventDelete` where
the default branch ref needs swapped in, but this was sufficient for my
use case.
 		2023-04-06 20:37:08 -04:00
..
clear_tasks.go Refactor commit status for Actions jobs (#23786) 2023-03-29 11:27:37 -04:00
commit_status.go Refactor commit status for Actions jobs (#23786) 2023-03-29 11:27:37 -04:00
init.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
job_emitter.go Refactor commit status for Actions jobs (#23786) 2023-03-29 11:27:37 -04:00
job_emitter_test.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
notifier.go Fix incorrect `HookEventType` of pull request review comments (#23650) 2023-03-24 13:13:04 +08:00
notifier_helper.go Actions: Use default branch as ref when a branch/tag delete occurs (#23910) 2023-04-06 20:37:08 -04:00