community
/
gitea
3
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
gitea/models
History
Lunny Xiao e8b6d28ab9
Fix bug hidden on CI and make ci failed if tests failure (#29254) (#29662) 
Backport #29254 

The tests on migration tests failed but CI reports successfully


https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migrations and also the CI hidden behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
 		2024-03-09 09:44:02 +00:00
..
actions Fix schedule tasks bugs (#28691) (#28780) 2024-01-14 23:54:22 +01:00
activities Avoid issue info panic (#29625) (#29632) 2024-03-06 13:33:29 +00:00
admin Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
asymkey Retry SSH key verification with additional CRLF if it failed (#28392) (#28464) 2023-12-14 12:50:26 +08:00
auth Fix bug when the linked account was disactived and list the linked accounts (#29263) 2024-02-19 15:23:47 +00:00
avatars Refactor system setting (#27000) (#27452) 2023-10-05 10:37:59 +00:00
db Avoid cycle-redirecting user/login page (#28636) (#28658) 2023-12-30 20:50:08 +08:00
dbfs Fix content holes in Actions task logs file (#25560) 2023-06-28 19:07:29 +02:00
fixtures Fix reverting a merge commit failing (#28794) (#28825) 2024-01-21 14:18:37 +00:00
git Fix `GetCommitStatuses` (#28787) (#28804) 2024-01-15 19:30:12 +01:00
issues Add missing database transaction for new issue (#29490) (#29607) 2024-03-05 16:37:55 +00:00
migrations Fix bug hidden on CI and make ci failed if tests failure (#29254) (#29662) 2024-03-09 09:44:02 +00:00
organization Another round of `db.DefaultContext` refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
packages Fix incorrect relative/absolute URL usages (#29531) (#29547) 2024-03-02 18:00:15 +00:00
perm Users with `read` permission of pull requests can be assigned too (#27263) (#29372) 2024-02-24 17:42:33 +01:00
project Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
pull refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo Users with `read` permission of pull requests can be assigned too (#27263) (#29372) 2024-02-24 17:42:33 +01:00
secret Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
shared/types Display owner of a runner as a tooltip instead of static text (#24377) 2023-05-12 08:43:27 +00:00
system Increase "version" when update the setting value to a same value as before (#28243) (#28244) 2023-11-28 01:58:39 +08:00
unit Use `Set[Type]` instead of `map[Type]bool/struct{}`. (#26804) 2023-08-30 06:55:25 +00:00
unittest Workaround to clean up old reviews on creating a new one (#28554) (#29264) 2024-02-19 16:48:58 +00:00
user Only use supported sort order for "explore/users" page (#29430) (#29443) 2024-03-03 02:28:45 +00:00
webhook Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
error.go Forbid removing the last admin user (#28337) (#28793) 2024-01-16 01:51:46 +00:00
fixture_generation.go Fix yaml test (#27297) (#27303) 2023-09-27 15:05:35 +08:00
fixture_test.go Fix yaml test (#27297) (#27303) 2023-09-27 15:05:35 +08:00
main_test.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
org.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
org_team.go Use db.WithTx for AddTeamMember to avoid ctx abuse (#27095) 2023-09-16 12:54:23 +00:00
org_team_test.go Reduce usage of `db.DefaultContext` (#27073) 2023-09-14 17:09:32 +00:00
org_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Refactor system setting (#27000) (#27452) 2023-10-05 10:37:59 +00:00
repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_transfer.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
repo_transfer_test.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00