From a5ac4c64fcf3de3d9441c241a07ce8610e3f399a Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 27 Feb 2017 08:36:42 +0800 Subject: [PATCH] refactor api issues load attributes for better performance (#1066) --- routers/api/v1/repo/issue.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/routers/api/v1/repo/issue.go b/routers/api/v1/repo/issue.go index c65f4b7063..9afde1f5ed 100644 --- a/routers/api/v1/repo/issue.go +++ b/routers/api/v1/repo/issue.go @@ -40,13 +40,14 @@ func ListIssues(ctx *context.APIContext) { issues = append(issues, tempIssues...) } - // FIXME: use IssueList to improve performance. + err = models.IssueList(issues).LoadAttributes() + if err != nil { + ctx.Error(500, "LoadAttributes", err) + return + } + apiIssues := make([]*api.Issue, len(issues)) for i := range issues { - if err = issues[i].LoadAttributes(); err != nil { - ctx.Error(500, "LoadAttributes", err) - return - } apiIssues[i] = issues[i].APIFormat() }