From 6c73c0da530649d0d629359e13d0373b72568f41 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 5 Sep 2023 19:15:42 +0800 Subject: [PATCH] Move ui notification to service layer (#26907) Extract from #22266 --- modules/notification/notification.go | 2 -- routers/init.go | 2 ++ .../ui/ui.go => services/uinotification/notify.go | 9 ++++++++- 3 files changed, 10 insertions(+), 3 deletions(-) rename modules/notification/ui/ui.go => services/uinotification/notify.go (98%) diff --git a/modules/notification/notification.go b/modules/notification/notification.go index 093113dcbe..c265388a18 100644 --- a/modules/notification/notification.go +++ b/modules/notification/notification.go @@ -14,7 +14,6 @@ import ( "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/notification/action" "code.gitea.io/gitea/modules/notification/base" - "code.gitea.io/gitea/modules/notification/ui" "code.gitea.io/gitea/modules/repository" ) @@ -28,7 +27,6 @@ func RegisterNotifier(notifier base.Notifier) { // NewContext registers notification handlers func NewContext() { - RegisterNotifier(ui.NewNotifier()) RegisterNotifier(action.NewNotifier()) } diff --git a/routers/init.go b/routers/init.go index ad7da70718..f311b4f95d 100644 --- a/routers/init.go +++ b/routers/init.go @@ -48,6 +48,7 @@ import ( repo_service "code.gitea.io/gitea/services/repository" "code.gitea.io/gitea/services/repository/archiver" "code.gitea.io/gitea/services/task" + "code.gitea.io/gitea/services/uinotification" "code.gitea.io/gitea/services/webhook" ) @@ -119,6 +120,7 @@ func InitWebInstalled(ctx context.Context) { mailer.NewContext(ctx) mustInit(cache.NewContext) notification.NewContext() + mustInit(uinotification.Init) mustInit(archiver.Init) highlight.NewContext() diff --git a/modules/notification/ui/ui.go b/services/uinotification/notify.go similarity index 98% rename from modules/notification/ui/ui.go rename to services/uinotification/notify.go index 2ca1a7700f..4cf74b6f1a 100644 --- a/modules/notification/ui/ui.go +++ b/services/uinotification/notify.go @@ -1,7 +1,7 @@ // Copyright 2018 The Gitea Authors. All rights reserved. // SPDX-License-Identifier: MIT -package ui +package uinotification import ( "context" @@ -14,6 +14,7 @@ import ( "code.gitea.io/gitea/modules/container" "code.gitea.io/gitea/modules/graceful" "code.gitea.io/gitea/modules/log" + "code.gitea.io/gitea/modules/notification" "code.gitea.io/gitea/modules/notification/base" "code.gitea.io/gitea/modules/queue" ) @@ -32,6 +33,12 @@ type ( } ) +func Init() error { + notification.RegisterNotifier(NewNotifier()) + + return nil +} + var _ base.Notifier = ¬ificationService{} // NewNotifier create a new notificationService notifier