From 3f253b3f5ad7f680f8144927c2ac4e05d57b7d5e Mon Sep 17 00:00:00 2001 From: Giteabot Date: Sat, 18 Mar 2023 21:37:16 -0400 Subject: [PATCH] Fix some broken css (#23560) (#23567) Backport #23560 by @wxiaoguang 1. The "close" inside "modal" are likely broken for long time * There is no var called `--body-color` * There is no `fullscreen modal` * The `.ui.modal > .close.inside` doesn't seem to match most icons. It only matches a few like "fork-repo-modal" or "adopt repo". Other places are just buggy code copied again and again. 2. Convert the legacy `&:hover` LESS syntax to CSS syntax Co-authored-by: wxiaoguang Co-authored-by: delvh --- web_src/css/base.css | 6 ++---- web_src/css/code/linebutton.css | 8 ++++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/web_src/css/base.css b/web_src/css/base.css index 275cd1cce4..f7b9442cfa 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -1173,10 +1173,8 @@ a.ui.card:hover, border-color: var(--color-secondary); } -.ui.modal > .close.inside, -.ui.fullscreen.modal > .close { - top: 11px; /* align modal close icon, for example admin notices */ - color: var(--body-color); +.ui.modal > .close.inside { + color: var(--color-text); } .ui.basic.table > tbody > tr { diff --git a/web_src/css/code/linebutton.css b/web_src/css/code/linebutton.css index a2956ffc1f..1012b38ba9 100644 --- a/web_src/css/code/linebutton.css +++ b/web_src/css/code/linebutton.css @@ -17,8 +17,8 @@ left: 0; transform: translateX(-70%); cursor: pointer; - - &:hover { - color: var(--color-primary); - } +} + +.code-line-button:hover { + color: var(--color-primary); }