From 001d3fb8209302d3083aae4017c932cbf53e0bef Mon Sep 17 00:00:00 2001 From: Giteabot Date: Thu, 6 Apr 2023 18:38:34 -0400 Subject: [PATCH] Delete deleted release attachments immediately from storage (#23913) (#23958) Backport #23913 by @lunny Previously, deleted release attachments were kept forever on the external storage. Note: It may be very slow now if there are many attachments to be deleted on this release. Fix #23728 Co-authored-by: Lunny Xiao --- services/release/release.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/release/release.go b/services/release/release.go index eec03b4688..a9a5231197 100644 --- a/services/release/release.go +++ b/services/release/release.go @@ -227,7 +227,7 @@ func UpdateRelease(doer *user_model.User, gitRepo *git.Repository, rel *repo_mod deletedUUIDs.Add(attach.UUID) } - if _, err := repo_model.DeleteAttachments(ctx, attachments, false); err != nil { + if _, err := repo_model.DeleteAttachments(ctx, attachments, true); err != nil { return fmt.Errorf("DeleteAttachments [uuids: %v]: %w", delAttachmentUUIDs, err) } }