From dec03ea3d85d66f7681648c502260ea3cf370143 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 9 May 2023 12:36:32 +0200 Subject: [PATCH] update golangci-lint to v1.52 Removing the "structcheck" and "varcheck" linters as they've been deprecated. level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused." level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused." Signed-off-by: Sebastiaan van Stijn --- .golangci.yml | 10 ++++++++-- dockerfiles/lint.Dockerfile | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index c64ba6e7..64a494b4 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,7 +1,5 @@ linters: enable: - - structcheck - - varcheck - staticcheck - unconvert - gofmt @@ -14,6 +12,14 @@ linters: disable: - errcheck +linters-settings: + revive: + rules: + # TODO(thaJeztah): temporarily disabled the "unused-parameter" check. + # It produces many warnings, and some of those may need to be looked at. + - name: unused-parameter + disabled: true + run: deadline: 2m skip-dirs: diff --git a/dockerfiles/lint.Dockerfile b/dockerfiles/lint.Dockerfile index 113db75a..da5e51b6 100644 --- a/dockerfiles/lint.Dockerfile +++ b/dockerfiles/lint.Dockerfile @@ -2,7 +2,7 @@ ARG GO_VERSION=1.18 ARG ALPINE_VERSION=3.16 -ARG GOLANGCI_LINT_VERSION=v1.45 +ARG GOLANGCI_LINT_VERSION=v1.52 FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint