67945c119e
A bunch of golint fixes
...
The proposed vars names are a nono, because they break the API.
Things left: document each RR and zscan_rr.go has some funcky if-then-elses.
2015-02-19 09:58:33 +00:00
fe160dfba4
minor clean ups: use time.Second instead of 1e9, do not reference ns as time.Duration is enough
2015-01-15 23:11:11 +01:00
0aa3021a83
Remove all copyright notices
...
Use the central COPYRIGHT file.
2014-09-11 20:57:37 +01:00
17c7921aa2
Documentation updates
2014-07-31 08:48:26 +00:00
0258525f20
Comment tweak
2014-02-14 22:47:53 +00:00
e81b46d580
Add client.UDPsize
...
This allows a client to set a default UDPSize with resorting to EDNS0
headers 'n stuff.
2014-02-14 22:14:41 +00:00
2cfad667d7
msg.Copy() makes a deep-copy of the msg object
...
There was a copy function that did shallow copies of the msg
object. Export it and make it support proper deep copying.
2014-01-10 08:49:45 -08:00
52f9a59ac1
Cleanup singleFlight a bit
2014-01-08 10:10:39 +00:00
f094f37de3
Add shortbuf erorr too
...
Cleanup the pull request a bit.
2014-01-04 11:17:13 +00:00
b1f108f79c
Simplify client TCP write.
...
Use the same patch as in the server.
2014-01-04 08:30:08 +00:00
451c12da09
typo
2013-12-30 16:46:53 +00:00
902ff847c8
Update Exchange documention about retries
...
Exchange does not fallback to tcp, nor will retry the query. Make
this more clear.
2013-12-27 07:48:30 +00:00
37a1ae569b
Remove this tidbit of documentation
...
A nil client is wrong. Just remove the sentence instead of coming
up with something that is technically correct, but doesn't read
nicely.
Closes : #60
2013-11-21 13:27:20 +00:00
9b15d749d8
remove newline
2013-11-01 09:51:50 +00:00
81fb20e093
Actually make the conn
2013-11-01 09:50:55 +00:00
37c7c70289
Use the Dial and DialTimeout function internally
2013-11-01 09:42:55 +00:00
d789796e53
Add Dial and DialTimeout to the client api.
...
This is just to mimic net as much as possible.
2013-11-01 09:40:44 +00:00
717a8179f5
Use recommendation from RFC5966 and set idle timeout much lower
2013-10-19 22:00:17 +01:00
ed0b128bd2
Add some groundwork for implementing rfc5966 recommendations
2013-10-18 11:59:19 +00:00
4b1cacf2d2
Update the doc a little
2013-10-18 09:14:31 +00:00
86186e27e4
Just use Read
2013-10-12 18:47:11 +01:00
aa44c75b91
Merge net branch
2013-10-12 18:32:53 +01:00
68083bc956
Fix merge conflict from net branch
2013-10-12 17:59:46 +01:00
7691523300
Re-add ExchangeConn
...
ExchangeConn is back, but with a warning. Other various improvements.
2013-10-12 12:44:02 +01:00
97603e3f62
Readd ExchangeConn
2013-10-12 12:35:09 +01:00
77d78f3218
More xfr fixes, does not work yet
2013-10-11 22:34:04 +01:00
ca3c488ad8
Fix transfer
2013-10-11 16:36:37 +00:00
b987dc6246
More transfer stuff
2013-10-11 16:18:37 +00:00
403baeb73a
Rework the transfers stuff
2013-10-02 20:35:13 +01:00
7f3472cc74
Patching to make compatible with appengine/socket.
...
The interface conversion from socket.Conn to net.UDPConn fails, but
since you can use a generic Read(b) in place of ReadFromUDP(b) it makes
sense to git rid of the conversion to net.UDPConn. This change allows
the use of the client library for UDP DNS lookup using the
appengine/socket package's Conn.
For the same reasons the interface conversions for TCP connections were
also removed.
2013-10-02 11:41:26 -04:00
db3de29edc
doc updates
2013-09-29 20:30:04 +01:00
b02f1b5203
Add Timeouts back in.
...
Fix the timeouts
2013-09-29 11:46:39 +01:00
500a32e64f
Update all the tests
2013-09-29 11:26:02 +01:00
9a38f97391
Fix timeouts, Tsig and EDNS0 update size
2013-09-29 11:21:18 +01:00
b97b3340fb
Make TSIG work again
...
Start fixing and using the UDP bufsize option.
2013-09-29 10:22:27 +01:00
4bde528be5
Export dns.Conn and make it more like net.Conn
...
Export lowlevel function and types so that they may be used.
They higher level Exchange function is still there. ExchangeConn
is gone, because it is not needed.
2013-09-28 21:58:08 +01:00
22977491c3
Try to use Conn
2013-09-28 20:31:29 +01:00
2b6e9122bd
Use the better name: SingleInflight
2013-09-06 09:49:07 +00:00
bb71be0271
Implement outstanding query detection.
...
Copied from the standard library and adapted to Go DNS.
2013-08-24 02:28:58 +00:00
d117fda34b
Perform query inflight deduplication
...
Taking a queue from Go tip, I copied over the new code and tweaked
it a bit for use in Go DNS.
2013-08-23 22:56:34 +00:00
3457c0428d
Some work in outstanding query de-deplication
2013-08-23 20:29:52 +00:00
11d592bfa7
client.Retry does not do anything
...
Remove from the struct as it was not implemented.
2013-06-15 20:35:09 +01:00
f595bf7a06
Set license on test files
2013-05-12 16:09:52 +02:00
19d93e2181
Fix it
2013-01-28 21:49:23 +01:00
6dfe504a09
small cleanups
2013-01-28 20:41:17 +01:00
73b9284ec7
remove dead code
2013-01-28 20:40:41 +01:00
23483f7959
Make it compile
2013-01-28 20:32:36 +01:00
0dc922a99b
Add a ExchangeConn
2013-01-28 20:30:13 +01:00
c8f880217f
Close the connection
...
Patch from: Alex Sergeyev
2013-01-28 19:27:24 +01:00
4ba5ac6863
Remove client.Attempts
...
Didn't like it anyway and it made the calling logic a mess. So it is
now removed. Failed queries can be redone, but they should be initiated
from the client, not within the library.
2013-01-11 19:20:49 +01:00
e66c2a1324
m.Size isnt used
2012-12-14 13:33:24 +01:00
3609f3e7a5
gofmt -s
2012-12-09 19:07:31 +01:00
d758825590
more documentation
2012-12-02 10:14:53 +01:00
1297852fdc
Fix tcp read/writes and client.Attempts
...
Thanks to a bug report from Vitalie Cherpec which commented that this
didn't work.
The timeout settings we not in the client.attempts loop, so they
were only active for the first attempt. And the loop wasn't broken
out of when the write or read succeeded.
Both these issues are now fixed.
2012-11-22 15:06:21 +01:00
c7ad10314a
Remove the Do function -- easy to do in standard Go
2012-11-19 18:14:09 +01:00
33e3a5396e
Dont even bother do allocate a channel
2012-11-19 16:55:14 +01:00
e2ca025569
update documentation
2012-11-19 16:22:54 +01:00
5349c3532f
Per suggestion of Jan Mercle
2012-11-19 14:43:02 +01:00
a0b6e30da7
Fix chaos.go for the new api
2012-11-18 13:51:42 +01:00
553b780257
Rearrange some comments
2012-11-18 13:28:16 +01:00
b34501bc1a
add remark
2012-11-18 13:12:11 +01:00
cbf025827a
Fix the documentation
2012-11-18 13:03:11 +01:00
ccaa90b31e
Make client.Do() return a channel (ala time.NewTicker)
...
This new API finally makes sense, and ditches the callback
2012-11-18 12:50:22 +01:00
099d0c1fc7
Add exchange structure for the client
2012-11-18 12:33:56 +01:00
3c3d2af072
Remove the Rtt variants
2012-11-18 12:29:40 +01:00
ea947838d8
Do the TCP write in one write
...
Before the tcp writes were done like NSD does them:
2 bytes length, and the rest of the message.
Now a complete buffer is created with LLMMM...MMM, where
LL is the 2 byte length and MMM...MMM is the message to be send.
This makes the reply faster at the cost of doing a realloc of the
message buffer.
2012-10-17 12:40:57 +02:00
1cca340f0b
Use attemps also in the dial function
2012-10-17 09:05:26 +02:00
bf1e1e15dc
docs
2012-10-16 19:14:03 +02:00
56221057d3
exchangeBuffer was and is not needed
2012-10-16 13:18:59 +02:00
be0423d80f
Tsig for queries is working again
2012-10-16 09:42:38 +02:00
2d3630ac98
refacter the client code a bit and remove the duplicate code
2012-10-16 09:36:52 +02:00
3089111fa4
calculate tsig in the normal query path too
2012-10-16 08:50:53 +02:00
39b9f93167
Fix tsig in the normal sending of queries
2012-10-15 20:00:49 +02:00
570bf8dc69
Use proper error in packing and unpacking
...
All the relevant functions now return an error instead of
a simple boolean. This greatly approves the feedback to coders.
Spotted some fishy error handling along the way and fix that too.
2012-10-09 21:17:54 +02:00
6e9317868b
doc tweaks
2012-09-01 17:06:24 +02:00
ff946625a6
small tweaks
2012-09-01 16:57:15 +02:00
7a0877d090
Merge conflict fixed
2012-08-31 15:10:43 +02:00
90a2076d8d
We were dialing twice
2012-08-31 14:55:47 +02:00
9255ad61ac
outgoing xfr works, but not for my Go code
2012-08-28 21:36:25 +02:00
68961f2f5b
Make the IsTsig and IsEdn0 more usefull by returning the record
2012-08-25 11:24:01 +02:00
15f03a72fb
Not needed
2012-08-23 10:33:33 +02:00
a8b3c8139b
Clean up the client
2012-08-17 08:45:26 +02:00
b720003623
make api smaller
2012-08-17 08:31:38 +02:00
1958fd2031
Fix compile errors
2012-08-08 09:45:31 +02:00
a282683f7c
Add DoRtt
2012-08-08 09:38:23 +02:00
37ff3f9f84
Add DROP and READXFR
2012-08-07 12:33:31 +02:00
cf84dce538
Update the todo
2012-08-06 20:39:35 +02:00
eec679d102
Remove hijacked
2012-08-06 20:34:09 +02:00
9ac8d2d7de
RequestWriter can go too
2012-08-06 20:09:45 +02:00
7de64f0dda
remove all the async query stuff in favor of the new Do()
2012-08-06 20:08:48 +02:00
f090b34c40
Use the new api - now on to fixing Tsig
2012-08-06 20:03:46 +02:00
e628564f33
Fix attempts in the client
2012-08-05 18:36:36 +02:00
51e13a15c9
snapshot
2012-08-05 18:13:23 +02:00
a113c7acd8
bug fix
2012-07-05 15:37:06 +02:00
6930a3a307
Tweaks for get a secure lookup going
2012-06-05 09:31:50 +02:00
53b065793b
More preparation for the root
2012-06-03 09:35:39 +02:00
bb376b18b3
Add size received to a pkt
2012-06-01 10:05:27 +02:00
530d66a85b
Set the channels in Do()
2012-05-26 12:02:37 +02:00
9c4c5f5369
remove NewClient from the code
2012-05-26 10:28:32 +02:00
458a74b8ce
remove the need for NewClient()
2012-05-26 10:24:47 +02:00
Miek Gieben
StalkR
Marek Majkowski
Eric Gavaletz