diff --git a/dnssec.go b/dnssec.go index f81e16d3..bb465c6e 100644 --- a/dnssec.go +++ b/dnssec.go @@ -65,7 +65,6 @@ func (k *RR_DNSKEY) KeyTag() uint16 { var keytag int switch k.Algorithm { case AlgRSAMD5: - println("Keytag RSAMD5. Todo") keytag = 0 default: keywire := new(dnskeyWireFmt) @@ -208,14 +207,12 @@ func (s *RR_RRSIG) Sign(k PrivateKey, rrset RRset) bool { wire := make([]byte, DefaultMsgSize) off, ok1 := packRR(r, wire, 0) if !ok1 { - println("Failure to pack") return false } wire = wire[:off] h.Ttl = ttl // restore the order in the universe h.Name = name if !ok1 { - println("Failure to pack") return false } signdata = append(signdata, wire...) @@ -339,14 +336,12 @@ func (s *RR_RRSIG) Verify(k *RR_DNSKEY, rrset RRset) bool { wire := make([]byte, DefaultMsgSize) off, ok1 := packRR(r, wire, 0) if !ok1 { - println("Failure to pack") return false } wire = wire[:off] h.Ttl = ttl // restore the order in the universe h.Name = name if !ok1 { - println("Failure to pack") return false } signeddata = append(signeddata, wire...) diff --git a/msg.go b/msg.go index c17ddeb6..b2971a95 100644 --- a/msg.go +++ b/msg.go @@ -729,9 +729,7 @@ func unpackRR(msg []byte, off int) (rr RR, off1 int, ok bool) { rr = mk() off, ok = unpackStruct(rr, msg, off0) if off != end { - // added MG - // println("Hier gaat het dan fout, echt waar en was if off0", off0) - return &h, end, true // TIJDELIJK EVEN WEG + return &h, end, true } return rr, off, ok } @@ -896,6 +894,7 @@ func (dns *Msg) Unpack(msg []byte) bool { return false } if off != len(msg) { + // TODO(mg) remove eventually println("extra bytes in dns packet", off, "<", len(msg)) } return true