community
/
dns
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix length overrun in EDNS0 parsing. 

Original text: (in Dutch)

Ik kreeg crashes (index out of range) in het parsen van een EDNS0_LLQ
optie, doordat de method: 'func (e *EDNS0_LLQ) unpack(b []byte)' een
byte slice van 1 byte groot kreeg waar dan meerdere uint16's uit gelezen
werden.
This commit is contained in:
Pieter de Boer 2014-01-24 10:10:44 +01:00 committed by Miek Gieben
parent a627d88e3f
commit e32b05768f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
edns.go
View File

@ -345,6 +345,9 @@ func (e *EDNS0_UL) pack() ([]byte, error) {
func (e *EDNS0_UL) Option() uint16 { return EDNS0UL }
func (e *EDNS0_UL) unpack(b []byte) {
if len(b) < 4 {
return
}
e.Lease = uint32(b[0])<<24 | uint32(b[1])<<16 | uint32(b[2])<<8 | uint32(b[3])
}
func (e *EDNS0_UL) String() string { return strconv.FormatUint(uint64(e.Lease), 10) }
@ -383,6 +386,9 @@ func (e *EDNS0_LLQ) pack() ([]byte, error) {
}
func (e *EDNS0_LLQ) unpack(b []byte) {
if len(b) < 18 {
return
}
e.Version, _ = unpackUint16(b, 0)
e.Opcode, _ = unpackUint16(b, 2)
e.Error, _ = unpackUint16(b, 4)