From cb9ec711f513ba74196008019d24d63cfd2190f9 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sun, 25 Aug 2013 21:38:10 -0700 Subject: [PATCH] Add (failing) test for zero rdata --- client_test.go | 3 +-- dns_test.go | 13 +++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/client_test.go b/client_test.go index 04d43b7f..63b6f326 100644 --- a/client_test.go +++ b/client_test.go @@ -90,8 +90,7 @@ func TestClientTsigAXFR(t *testing.T) { if a, err := c.TransferIn(m, "37.251.95.53:53"); err != nil { t.Log("Failed to setup axfr: " + err.Error()) - t.Fail() - return + t.Fatal() } else { for ex := range a { if ex.Error != nil { diff --git a/dns_test.go b/dns_test.go index 14a44a27..9f7fba84 100644 --- a/dns_test.go +++ b/dns_test.go @@ -240,3 +240,16 @@ func TestToRFC3597(t *testing.T) { t.Fail() } } + +func TestNoRdata(t *testing.T) { + data := make([]byte, 1024) + for typ, _ := range TypeToString { + r := rr_mk[typ]() + *r.Header() = RR_Header{Name: "miek.nl.", Rrtype: typ, Class: ClassINET, Ttl: 3600} + _, e := PackRR(r, data, 0, nil, false) + if e != nil { + t.Logf("Failed to pack rdata zero RR %d: %s\n", typ, e.Error()) + t.Fail() + } + } +}