From ab67d69d9b35fd474ad22a8820d4755e0d798d6b Mon Sep 17 00:00:00 2001
From: Miek Gieben <miek@miek.nl>
Date: Wed, 28 Nov 2018 22:25:28 +0000
Subject: [PATCH] review

Signed-off-by: Miek Gieben <miek@miek.nl>
---
 server.go      | 10 ++++++----
 server_test.go |  1 -
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/server.go b/server.go
index c5a0a4d6..9d33d6f0 100644
--- a/server.go
+++ b/server.go
@@ -642,11 +642,13 @@ func (srv *Server) serveDNS(w *response) {
 	req := new(Msg)
 	req.setHdr(dh)
 
-	if action := srv.MsgAcceptFunc(dh); action != MsgAccept {
-		if action == MsgIgnore {
-			return
-		}
+	switch srv.MsgAcceptFunc(dh) {
+	case MsgAccept:
 
+	case MsgIgnore:
+		return
+
+	case MsgReject:
 		req.SetRcodeFormatError(req)
 		// Are we allowed to delete any OPT records here?
 		req.Ns, req.Answer, req.Extra = nil, nil, nil
diff --git a/server_test.go b/server_test.go
index 58b4cde9..d850b8e4 100644
--- a/server_test.go
+++ b/server_test.go
@@ -102,7 +102,6 @@ func RunLocalTCPServerWithFinChan(laddr string) (*Server, string, chan error, er
 	}
 
 	server := &Server{Listener: l, ReadTimeout: time.Hour, WriteTimeout: time.Hour}
-	server.init()
 
 	waitLock := sync.Mutex{}
 	waitLock.Lock()