From 9f5db7b72cd1c872fae903ac7739099e722f5131 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Tue, 7 Jan 2014 07:44:06 +0000 Subject: [PATCH] Disable the unfinished CAA support CAA was partially implemented, it's better to do it 100% until that time handle CAA as an unknown record. Closes #70: --- msg.go | 6 ------ types.go | 5 ++++- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/msg.go b/msg.go index 45ab6001..a6ec49cb 100644 --- a/msg.go +++ b/msg.go @@ -454,8 +454,6 @@ func packStructValue(val reflect.Value, msg []byte, off int, compression map[str return lenmsg, err } } - case `dns:"octect"`: - println("TODO") case `dns:"txt"`: for j := 0; j < val.Field(i).Len(); j++ { element := val.Field(i).Index(j).String() @@ -1095,10 +1093,6 @@ func unpackStructValue(val reflect.Value, msg []byte, off int) (off1 int, err er } s = hex.EncodeToString(msg[off : off+size]) off += size - case `dns:"octet"`: - // used in CAA - // rdlength := int(val.FieldByName("Hdr").FieldByName("Rdlength").Uint()) - // TODO(miek): finish case `dns:"txt"`: rdlength := int(val.FieldByName("Hdr").FieldByName("Rdlength").Uint()) Txt: diff --git a/types.go b/types.go index 5a8b4670..4cf87e00 100644 --- a/types.go +++ b/types.go @@ -1365,6 +1365,8 @@ func (rr *EUI64) copy() RR { return &EUI64{*rr.Hdr.copyHeader(), rr.Ad func (rr *EUI64) String() string { return rr.Hdr.String() + euiToString(rr.Address, 64) } func (rr *EUI64) len() int { return rr.Hdr.len() + 8 } +// Support in incomplete - just handle it as unknown record +/* type CAA struct { Hdr RR_Header Flag uint8 @@ -1381,6 +1383,7 @@ func (rr *CAA) String() string { s += strconv.QuoteToASCII(rr.Value) return s } +*/ type UID struct { Hdr RR_Header @@ -1504,7 +1507,7 @@ var rr_mk = map[uint16]func() RR{ TypeA: func() RR { return new(A) }, TypeAAAA: func() RR { return new(AAAA) }, TypeAFSDB: func() RR { return new(AFSDB) }, - TypeCAA: func() RR { return new(CAA) }, +// TypeCAA: func() RR { return new(CAA) }, TypeCDS: func() RR { return new(CDS) }, TypeCERT: func() RR { return new(CERT) }, TypeCNAME: func() RR { return new(CNAME) },