Changed label splitting and fixed behavior for final period in names.

idn/punycode.go

@@ -3,6 +3,8 @@ package idn
 
 import (
 	"bytes"
+	"github.com/miekg/dns"
+	"strings"
 	"unicode"
 )
 
@@ -28,20 +30,34 @@ const (
 // This function would return incorrect result for strings for non-canonical
 // unicode strings.
 func ToPunycode(s string) string {
-	tokens := bytes.Split([]byte(s), []byte{'.'})
-	for i := range tokens {
-		tokens[i] = encodeBytes(tokens[i])
+	tokens := dns.SplitDomainName(s)
+	if s[len(s)-1] == '.' {
+		if tokens == nil {
+			tokens = []string{"", ""}
+		} else {
+			tokens = append(tokens, "")
+		}
 	}
-	return string(bytes.Join(tokens, []byte{'.'}))
+	for i := range tokens {
+		tokens[i] = string(encodeBytes([]byte(tokens[i])))
+	}
+	return strings.Join(tokens, ".")
 }
 
 // FromPunycode returns uncode domain name from provided punycode string.
 func FromPunycode(s string) string {
-	tokens := bytes.Split([]byte(s), []byte{'.'})
-	for i := range tokens {
-		tokens[i] = decodeBytes(tokens[i])
+	tokens := dns.SplitDomainName(s)
+	if s[len(s)-1] == '.' {
+		if tokens == nil {
+			tokens = []string{"", ""}
+		} else {
+			tokens = append(tokens, "")
+		}
 	}
-	return string(bytes.Join(tokens, []byte{'.'}))
+	for i := range tokens {
+		tokens[i] = string(decodeBytes([]byte(tokens[i])))
+	}
+	return strings.Join(tokens, ".")
 }
 
 // digitval converts single byte into meaningful value that's used to calculate decoded unicode character.

idn/punycode_test.go

@@ -6,6 +6,7 @@ import (
 )
 
 var testcases = [][2]string{
+	{"", ""},
 	{"a", "a"},
 	{"A-B", "a-b"},
 	{"AbC", "abc"},
@@ -53,6 +54,21 @@ func TestToFromPunycode(t *testing.T) {
 	}
 }
 
+func TestEncodeDecodeFinalPeriod(t *testing.T) {
+	for _, tst := range testcases {
+		// assert unicode.com. == punycode.com.
+		full := ToPunycode(tst[0] + ".")
+		if full != tst[1]+"." {
+			t.Errorf("invalid result from string conversion to punycode when period added at the end, %#v and should be %#v", full, tst[1]+".")
+		}
+		// assert punycode.com. == unicode.com.
+		decoded := FromPunycode(tst[1] + ".")
+		if decoded != strings.ToLower(tst[0]+".") {
+			t.Errorf("invalid result from string conversion to punycode when period added, %#v and should be %#v", decoded, tst[0]+".")
+		}
+	}
+}
+
 var invalid = []string{
 	"xn--*",
 	"xn--",