From 9147aad21eae8888354f82a286339f7e41fe0e89 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sun, 9 Dec 2012 21:17:16 +0100 Subject: [PATCH] need to add test for dynamic updates --- TODO.markdown | 1 + msg.go | 1 + 2 files changed, 2 insertions(+) diff --git a/TODO.markdown b/TODO.markdown index a850cb3c..f0c1fc6e 100644 --- a/TODO.markdown +++ b/TODO.markdown @@ -5,6 +5,7 @@ * allow multiple edns0 options to exist in the record when converting from/to wireformat * NSEC3 support propper in the zone structure(s) +* Test all rdata packing with zero rdata -- allowed for dynamic updates ## Nice to have diff --git a/msg.go b/msg.go index ec821b90..774bfad8 100644 --- a/msg.go +++ b/msg.go @@ -464,6 +464,7 @@ func packStructValue(val reflect.Value, msg []byte, off int, compression map[str return lenmsg, &Error{Err: "overflow packing a"} } case `dns:"aaaa"`: + // fv.Len TODO(mg) dynamisc updates? if fv.Len() > net.IPv6len || off+fv.Len() > lenmsg { return lenmsg, &Error{Err: "overflow packing aaaa"} }