From 5ecc38c003489c1149de6e0f074d084fe436fc53 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Thu, 6 Feb 2014 10:32:38 +0000 Subject: [PATCH 1/2] Better docs --- msg.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/msg.go b/msg.go index 23c64793..411ee2ea 100644 --- a/msg.go +++ b/msg.go @@ -1436,9 +1436,9 @@ func (dns *Msg) Unpack(msg []byte) (err error) { return err } } - // If we have seen a TC bit being set, we return here, without - // an error, because technically it isn't an error. So we return - // without parsing, the potentially corrupt packet. + // If we see a TC bit being set we return here, without + // an error, because technically it isn't an error. So return + // without parsing the potentially corrupt packet and hitting an error. if dns.Truncated { dns.Answer = nil dns.Ns = nil From 1f066aa6d91e0b2d253b802ec4105f29f3f5cf58 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Fri, 7 Feb 2014 10:19:14 +0000 Subject: [PATCH 2/2] Test for procent in label names --- labels_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/labels_test.go b/labels_test.go index bcad98e6..b4cd0018 100644 --- a/labels_test.go +++ b/labels_test.go @@ -176,6 +176,7 @@ func TestIsDomainName(t *testing.T) { "..": &ret{false, 1}, "@.": &ret{true, 1}, "www.example.com": &ret{true, 3}, + "www.e%ample.com": &ret{true, 3}, "www.example.com.": &ret{true, 3}, "mi\\k.nl.": &ret{true, 2}, "mi\\k.nl": &ret{true, 2},