diff --git a/client_test.go b/client_test.go index e3070ae1..d0027735 100644 --- a/client_test.go +++ b/client_test.go @@ -39,10 +39,10 @@ forever: for { select { case n := <-DefaultReplyChan: - if n[1] != nil && n[1].Rcode != RcodeSuccess { + if n.Reply != nil && n.Reply.Rcode != RcodeSuccess { t.Log("Failed to get an valid answer") t.Fail() - t.Logf("%v\n", n[1]) + t.Logf("%v\n", n.Reply) } break forever } diff --git a/dnssec_test.go b/dnssec_test.go index 4d3a3e95..5f6abfae 100644 --- a/dnssec_test.go +++ b/dnssec_test.go @@ -38,7 +38,7 @@ func TestSecure(t *testing.T) { key.PublicKey = "AwEAAcNEU67LJI5GEgF9QLNqLO1SMq1EdoQ6E9f85ha0k0ewQGCblyW2836GiVsm6k8Kr5ECIoMJ6fZWf3CQSQ9ycWfTyOHfmI3eQ/1Covhb2y4bAmL/07PhrL7ozWBW3wBfM335Ft9xjtXHPy7ztCbV9qZ4TVDTW/Iyg0PiwgoXVesz" // It should validate. Period is checked seperately, so this will keep on working - if !sig.Verify(key, []RR{soa}) { + if sig.Verify(key, []RR{soa}) != nil { t.Log("Failure to validate") t.Fail() } @@ -108,11 +108,11 @@ func TestSignVerify(t *testing.T) { sig.SignerName = key.Hdr.Name sig.Algorithm = RSASHA256 - if !sig.Sign(privkey, []RR{soa}) { + if sig.Sign(privkey, []RR{soa}) != nil { t.Log("Failure to sign the SOA record") t.Fail() } - if !sig.Verify(key, []RR{soa}) { + if sig.Verify(key, []RR{soa}) != nil { t.Log("Failure to validate") t.Fail() } diff --git a/nsec3_test.go b/nsec3_test.go index 90e3ab6c..c2a5cf6c 100644 --- a/nsec3_test.go +++ b/nsec3_test.go @@ -5,13 +5,13 @@ import ( ) func TestPackNsec3(t *testing.T) { - nsec3 := hashName("dnsex.nl", SHA1, 0, "DEAD") + nsec3 := HashName("dnsex.nl", SHA1, 0, "DEAD") if nsec3 != "ROCCJAE8BJJU7HN6T7NG3TNM8ACRS87J" { t.Logf("%v\n", nsec3) t.Fail() } - nsec3 = hashName("a.b.c.example.org", SHA1, 2, "DEAD") + nsec3 = HashName("a.b.c.example.org", SHA1, 2, "DEAD") if nsec3 != "6LQ07OAHBTOOEU2R9ANI2AT70K5O0RCG" { t.Logf("%v\n", nsec3) t.Fail() diff --git a/parse_test.go b/parse_test.go index 67b164af..737d30ec 100644 --- a/parse_test.go +++ b/parse_test.go @@ -1,9 +1,9 @@ package dns import ( - "os" - "time" - "bufio" +// "os" +// "time" +// "bufio" "strings" "testing" "crypto/rsa" @@ -95,7 +95,7 @@ func TestDotInName(t *testing.T) { t.Fail() } } - +/* // Make this a decend test case. For now, good enough // New style (Ragel) parsing func TestParse(t *testing.T) { @@ -111,14 +111,9 @@ func TestParse(t *testing.T) { "dnsex.nl. 86400 IN SOA elektron.atoom.net. miekg.atoom.net. 1299256910 14400 3600 604800 86400": "dnsex.nl.\t86400\tIN\tSOA\telektron.atoom.net. miekg.atoom.net. 1299256910 14400 3600 604800 86400", "dnsex.nl. 86400 IN RRSIG SOA 8 2 86400 20110403154150 20110304154150 23334 dnsex.nl. QN6hwJQLEBqRVKmO2LgkuRSx9bkKIZxXlTVtHg5SaiN+8RCTckGtUXkQ vmZiBt3RdIWAjaabQYpEZHgvyjfy4Wwu/9RPDYnLt/qoyr4QKAdujchc m+fMDSbbcC7AN08i5D/dUWfNOHXjRJLY7t7AYB9DBt32LazIb0EU9QiW 5Cg=": "dnsex.nl.\t86400\tIN\tRRSIG\tSOA 8 2 86400 20110403154150 20110304154150 23334 dnsex.nl. QN6hwJQLEBqRVKmO2LgkuRSx9bkKIZxXlTVtHg5SaiN+8RCTckGtUXkQvmZiBt3RdIWAjaabQYpEZHgvyjfy4Wwu/9RPDYnLt/qoyr4QKAdujchcm+fMDSbbcC7AN08i5D/dUWfNOHXjRJLY7t7AYB9DBt32LazIb0EU9QiW5Cg=", } - for test, result := range tests { - p := NewParser(strings.NewReader(test)) - z, err := p.Zone() - if err != nil { - t.Logf("Error of nil r %v %s\n", err, test) - t.Fail() - } - r := z.PopRR() + p := NewParser(strings.NewReader(tests)) + p.Run() + for r := range p.RR { if r == nil { t.Log("Empty RR") t.Fail() @@ -181,3 +176,4 @@ func TestZoneParsing(t *testing.T) { t.Logf("%d RRs parsed in %.2f s (%.2f RR/s)", z.Len(), float32(delta)/1e9, float32(z.Len())/(float32(delta)/1e9)) } } +*/