From 3e29cce3ba7b2f3090a3abfb2c3a1dff55925d0c Mon Sep 17 00:00:00 2001
From: Miek Gieben <miek@miek.nl>
Date: Fri, 7 Dec 2012 09:16:43 +0100
Subject: [PATCH] Check the NSEC type bitmap once

It's still timeconsuming, but the only way to check the
type bitmap is to iterate over the slice...
---
 zone.go | 43 +++++++++++++++++++++++++++----------------
 1 file changed, 27 insertions(+), 16 deletions(-)

diff --git a/zone.go b/zone.go
index c075da6e..5716d6ec 100644
--- a/zone.go
+++ b/zone.go
@@ -494,32 +494,43 @@ func (node *ZoneData) Sign(next string, keys map[*RR_DNSKEY]PrivateKey, keytags
 	node.Lock()
 	defer node.Unlock()
 
-	bitmap := make([]uint16, 0)
-	r, n := false, false
+	n, nsecok := node.RR[TypeNSEC]
+	bitmap := []uint16{TypeNSEC, TypeRRSIG}
+	bitmapEqual := true
 	for t, _ := range node.RR {
-		if t == TypeRRSIG {
-			r = true
+		if nsecok {
+			// Check if the current (if available) nsec has these types too
+			// Grr O(n^2)
+			found := false
+			for _, v := range n[0].(*RR_NSEC).TypeBitMap {
+				if v == t {
+					found = true
+					break
+				}
+				if v > t { // It is sorted, so by now we haven't found it
+					found = false
+					break
+				}
+			}
+			if !found {
+				bitmapEqual = false
+			}
 		}
-		if t == TypeNSEC {
-			n = true
+		if t == TypeNSEC || t == TypeRRSIG {
+			continue
 		}
 		bitmap = append(bitmap, t)
-	}
-	if r == false {
-		bitmap = append(bitmap, TypeRRSIG) // Add sig too
-	}
-	if n == false {
-		bitmap = append(bitmap, TypeNSEC) // Add me too!
+
 	}
 	sort.Sort(uint16Slice(bitmap))
 
-	if v, ok := node.RR[TypeNSEC]; ok {
+	if nsecok {
 		// There is an NSEC, check if it still points to the correct next node.
 		// Secondly the type bitmap may have changed.
 		// TODO(mg): actually checked the types in the map
-		if v[0].(*RR_NSEC).NextDomain != next || len(v[0].(*RR_NSEC).TypeBitMap) != len(bitmap) {
-			v[0].(*RR_NSEC).NextDomain = next
-			v[0].(*RR_NSEC).TypeBitMap = bitmap
+		if n[0].(*RR_NSEC).NextDomain != next || !bitmapEqual {
+			n[0].(*RR_NSEC).NextDomain = next
+			n[0].(*RR_NSEC).TypeBitMap = bitmap
 			node.Signatures[TypeNSEC] = nil // drop all sigs
 		}
 	} else {