community
/
dns
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
dns/sanitize_test.go

76 lines
2.0 KiB
Go
Raw Normal View History

Add Dedup function Add function that dedups a list of RRs. Work on strings, which adds garbage, but seems to be the least intrusive and takes the last amount of memory. Some fmt changes snook in as well.
2015-08-24 21:02:32 +00:00
package dns
More and better tests
2015-08-26 06:34:51 +00:00
import "testing"
Add Dedup function Add function that dedups a list of RRs. Work on strings, which adds garbage, but seems to be the least intrusive and takes the last amount of memory. Some fmt changes snook in as well.
2015-08-24 21:02:32 +00:00
func TestDedup(t *testing.T) {
Rework a little and more tests
2015-08-25 21:35:10 +00:00
testcases := map[[3]RR][]string{
Cleanup the tests and add some doc string
2015-08-25 07:39:43 +00:00
[...]RR{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("mIek.nl. IN A 127.0.0.1"),
testRR("mieK.nl. IN A 127.0.0.1"),
testRR("miek.Nl. IN A 127.0.0.1"),
gofmt -s
2016-01-22 16:44:49 +00:00
}: {"mIek.nl.\t3600\tIN\tA\t127.0.0.1"},
Cleanup the tests and add some doc string
2015-08-25 07:39:43 +00:00
[...]RR{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("miEk.nl. 2000 IN A 127.0.0.1"),
testRR("mieK.Nl. 1000 IN A 127.0.0.1"),
testRR("Miek.nL. 500 IN A 127.0.0.1"),
gofmt -s
2016-01-22 16:44:49 +00:00
}: {"miEk.nl.\t500\tIN\tA\t127.0.0.1"},
Cleanup the tests and add some doc string
2015-08-25 07:39:43 +00:00
[...]RR{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("miek.nl. IN A 127.0.0.1"),
testRR("miek.nl. CH A 127.0.0.1"),
testRR("miek.nl. IN A 127.0.0.1"),
gofmt -s
2016-01-22 16:44:49 +00:00
}: {"miek.nl.\t3600\tIN\tA\t127.0.0.1",
Rework a little and more tests
2015-08-25 21:35:10 +00:00
"miek.nl.\t3600\tCH\tA\t127.0.0.1",
},
Cleanup the tests and add some doc string
2015-08-25 07:39:43 +00:00
[...]RR{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("miek.nl. CH A 127.0.0.1"),
testRR("miek.nl. IN A 127.0.0.1"),
testRR("miek.de. IN A 127.0.0.1"),
gofmt -s
2016-01-22 16:44:49 +00:00
}: {"miek.nl.\t3600\tCH\tA\t127.0.0.1",
More and better tests
2015-08-26 06:34:51 +00:00
"miek.nl.\t3600\tIN\tA\t127.0.0.1",
Rework a little and more tests
2015-08-25 21:35:10 +00:00
"miek.de.\t3600\tIN\tA\t127.0.0.1",
},
[...]RR{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("miek.de. IN A 127.0.0.1"),
testRR("miek.nl. 200 IN A 127.0.0.1"),
testRR("miek.nl. 300 IN A 127.0.0.1"),
gofmt -s
2016-01-22 16:44:49 +00:00
}: {"miek.de.\t3600\tIN\tA\t127.0.0.1",
More and better tests
2015-08-26 06:34:51 +00:00
"miek.nl.\t200\tIN\tA\t127.0.0.1",
Rework a little and more tests
2015-08-25 21:35:10 +00:00
},
Cleanup the tests and add some doc string
2015-08-25 07:39:43 +00:00
}
for rr, expected := range testcases {
less memory use
2015-08-31 15:48:28 +00:00
out := Dedup([]RR{rr[0], rr[1], rr[2]}, nil)
More and better tests
2015-08-26 06:34:51 +00:00
for i, o := range out {
if o.String() != expected[i] {
Correctly handle CNAME/DNAMEs
2015-08-26 11:19:22 +00:00
t.Fatalf("expected %v, got %v", expected[i], o.String())
More and better tests
2015-08-26 06:34:51 +00:00
}
Cleanup the tests and add some doc string
2015-08-25 07:39:43 +00:00
}
Add Dedup function Add function that dedups a list of RRs. Work on strings, which adds garbage, but seems to be the least intrusive and takes the last amount of memory. Some fmt changes snook in as well.
2015-08-24 21:02:32 +00:00
}
}
Address commments from Alex
2015-08-26 13:13:14 +00:00
func BenchmarkDedup(b *testing.B) {
rrs := []RR{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("miEk.nl. 2000 IN A 127.0.0.1"),
testRR("mieK.Nl. 1000 IN A 127.0.0.1"),
testRR("Miek.nL. 500 IN A 127.0.0.1"),
More and better tests
2015-08-26 06:34:51 +00:00
}
less memory use
2015-08-31 15:48:28 +00:00
m := make(map[string]RR)
Address commments from Alex
2015-08-26 13:13:14 +00:00
for i := 0; i < b.N; i++ {
gofmt -s
2016-01-22 16:44:49 +00:00
Dedup(rrs, m)
Rework a little and more tests
2015-08-25 21:35:10 +00:00
}
}
Add Dedup function Add function that dedups a list of RRs. Work on strings, which adds garbage, but seems to be the least intrusive and takes the last amount of memory. Some fmt changes snook in as well.
2015-08-24 21:02:32 +00:00
func TestNormalizedString(t *testing.T) {
tests := map[RR]string{
Tests updates (#556) Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
2017-11-08 10:01:19 +00:00
testRR("mIEk.Nl. 3600 IN A 127.0.0.1"): "miek.nl.\tIN\tA\t127.0.0.1",
testRR("m\\ iek.nL. 3600 IN A 127.0.0.1"): "m\\ iek.nl.\tIN\tA\t127.0.0.1",
testRR("m\\\tIeK.nl. 3600 in A 127.0.0.1"): "m\\009iek.nl.\tIN\tA\t127.0.0.1",
Add Dedup function Add function that dedups a list of RRs. Work on strings, which adds garbage, but seems to be the least intrusive and takes the last amount of memory. Some fmt changes snook in as well.
2015-08-24 21:02:32 +00:00
}
for tc, expected := range tests {
Address commments from Alex
2015-08-26 13:13:14 +00:00
n := normalizedString(tc)
if n != expected {
Use t.Errorf in tests and make the error variable naming more consistent. (#367) * Make the error variable always named err. Sometimes the error variable was named 'err' sometimes 'e'. Sometimes 'e' refered to an EDNS or string and not an error type. * Use t.Errorf instead of t.Logf & t.Fail.
2016-06-09 06:00:08 +00:00
t.Errorf("expected %s, got %s", expected, n)
Add Dedup function Add function that dedups a list of RRs. Work on strings, which adds garbage, but seems to be the least intrusive and takes the last amount of memory. Some fmt changes snook in as well.
2015-08-24 21:02:32 +00:00
}
}
}